[PATCH weston] compositor-fbdev: Remove bizarre division by sizeof

Bryce Harrington bryce at osg.samsung.com
Wed Sep 9 16:39:48 PDT 2015


On Wed, Sep 02, 2015 at 01:45:20PM -0500, Derek Foreman wrote:
> Really not sure why this was even here - it worked because
> we were dividing by 1.
> 
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

> ---
>  src/compositor-fbdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compositor-fbdev.c b/src/compositor-fbdev.c
> index a5c7947..81281d0 100644
> --- a/src/compositor-fbdev.c
> +++ b/src/compositor-fbdev.c
> @@ -337,7 +337,7 @@ fbdev_query_screen_info(struct fbdev_output *output, int fd,
>  
>  	info->buffer_length = fixinfo.smem_len;
>  	info->line_length = fixinfo.line_length;
> -	strncpy(info->id, fixinfo.id, sizeof(info->id) / sizeof(*info->id));
> +	strncpy(info->id, fixinfo.id, sizeof(info->id));
>  
>  	info->pixel_format = calculate_pixman_format(&varinfo, &fixinfo);
>  	info->refresh_rate = calculate_refresh_rate(&varinfo);
> -- 
> 2.5.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list