[PATCH weston] configure.ac: add support for new versions of systemd

Bryce Harrington bryce at osg.samsung.com
Fri Sep 25 18:05:58 PDT 2015


On Mon, Jul 13, 2015 at 10:03:46PM +0200, Frederico Cadete wrote:
> On Mon, Jul 13, 2015 at 8:21 PM, Quentin Glidic
> <sardemff7+wayland at sardemff7.net> wrote:
> > On 2015-07-13 18:07, Frederico Cadete wrote:
> >> I thought of doing that, but can't think of a way to do it without
> >> breaking someone's build.
> >>
> >> Currently, weston enables sd-login if it finds the corresponding .pc,
> >> and disables it if not. If I add a --enable-sd-login/--disable-sd-login,
> >> I see two choices:
> >>
> >> - Make --enable-sd-login the default. The build will fail if it does not
> >>   find libsystemd. People who don't have it will have to add --disable-sd-login
> >>   when calling configure.
> >> - Make --disable-sd-login the default. This will silently change the
> >>   builds of people who had libsystemd and expect it to come enabled.
> >>
> >> I am leaning for the first option, because the breakage is louder.
> >>
> >> Am I missing some way to do this better?
> >
> > See how the vaapi-recorder switch is doing it. You can force
> > enable/disable and the default is to auto-detect.
> 
> Doh.
> 
> I'll look it up and probably submit another patch in a few days.
> This one can go in independently as far as I am concerned.

Hi Frederico,

By chance have you had time to look at this option?
Right now would be a great time to land both the original patch and the
config option patch.  Looks like this is still quite relevant.

Bryce


More information about the wayland-devel mailing list