[PATCH] ivi-layout : clear on_layer when layer_destroy

Pekka Paalanen ppaalanen at gmail.com
Tue Apr 12 12:59:48 UTC 2016


On Mon, 11 Apr 2016 21:34:52 +0900
Wataru Natsume <wataru_natsume at xddp.denso.co.jp> wrote:

> On_layer of ivi_layout_surface should be NULL in the layer_destroy.
> Previous code might access to removed ivilayer and cause SEGV.
> 
> Signed-off-by: Wataru Natsume <wataru_natsume at xddp.denso.co.jp>
> ---
>  ivi-shell/ivi-layout.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
> index 5c0e8f4..23e3269 100644
> --- a/ivi-shell/ivi-layout.c
> +++ b/ivi-shell/ivi-layout.c
> @@ -973,6 +973,7 @@ clear_surface_order_list(struct ivi_layout_layer *ivilayer)
>  			      &ivilayer->order.surface_list, order.link) {
>  		wl_list_remove(&surface_link->order.link);
>  		wl_list_init(&surface_link->order.link);
> +		surface_link->on_layer = NULL;
>  	}
>  }
>  

Hi,

layer_destroy seems to be an immediate action as opposed to needing a
commit, so looks good. Pushed:
   48fbb54..7b3a52a  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160412/1de74c61/attachment.sig>


More information about the wayland-devel mailing list