[PATCH wayland-protocols] configure.ac: Don't use AC_CANONICAL_* macro calls

Jussi Kukkonen jussi.kukkonen at intel.com
Thu Feb 18 13:23:20 UTC 2016


On 18 February 2016 at 14:38, Quentin Glidic <
sardemff7+wayland at sardemff7.net> wrote:

> On 18/02/2016 13:29, Jussi Kukkonen wrote:
>
>> There's nothing in the build that requires knowledge of target or
>> host architecture, yet the calls will fail if the host cpu is not
>> recognised (which happens when e.g. Yocto builds for "allarch").
>>
>> Signed-off-by: Jussi Kukkonen <jussi.kukkonen at intel.com>
>> ---
>>   configure.ac | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 90cce42..596093b 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -15,9 +15,6 @@ AC_CONFIG_MACRO_DIR([m4])
>>
>>   AC_SUBST([WAYLAND_PROTOCOLS_VERSION], [wayland_protocols_version])
>>
>> -AC_CANONICAL_HOST
>> -AC_CANONICAL_BUILD
>> -
>>   AC_ARG_VAR([wayland_scanner], [The wayland-scanner executable])
>>   AC_PATH_PROG([wayland_scanner], [wayland-scanner])
>>   if test x$wayland_scanner = x; then
>>
>>
> These two calls are needed, see a few lines below:
> "if test x$host = x$build; then"
> $host and $build are only populated if we call these macros.
>
> Nacked-by: Quentin Glidic <sardemff7+git at sardemff7.net>
>
>
Oops, you're correct and I may be becoming blind. I'll have to figure out
another solution to this.

Thanks, Jussi


> --
>
> Quentin “Sardem FF7” Glidic
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160218/2f0f824c/attachment.html>


More information about the wayland-devel mailing list