[PATCH weston 3/5] ivi-shell: call send_surface_send_configure() directly

Pekka Paalanen pekka.paalanen at collabora.co.uk
Tue Mar 15 15:42:59 UTC 2016


On Tue, 15 Mar 2016 17:39:23 +0200
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> For some reason, it seems that ivi-layout.c has tried hard to avoid
> calling directly into ivi-shell.c. This means there is a jump through
> hoops just to get the configure event sent to the clients. Ivi-shell
> registers a listener for a ivi-layout signal for sending the event.
> 
> Instead, let ivi-layout.c call directly into ivi-shell.c, and expose a
> function to send out the configure events. This reduces some confusion
> on who calls what.
> 
> The main idea though is that this makes ivi-shell.c not depend on struct
> ivi_layout_surface fields directly anymore. In following patches,
> ivi_layout_surface can be made opaque for ivi-shell.c.
> 
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  ivi-shell/ivi-layout-transition.c |  4 ++++
>  ivi-shell/ivi-layout.c            | 13 +++++++++++--
>  ivi-shell/ivi-shell.c             | 40 ++++++++++++++++-----------------------
>  ivi-shell/ivi-shell.h             |  4 ++++
>  4 files changed, 35 insertions(+), 26 deletions(-)

> +void
> +shell_surface_send_configure(struct weston_surface *surface,
> +			     int32_t width, int32_t height);
> +
>  #endif /* WESTON_IVI_SHELL_H */

*Cough*

Obviously the subject should say "shell_surface_send_configure".


Thanks,
pq


More information about the wayland-devel mailing list