[PATCH wayland-protocols v2] Introduce xdg-foreign protocol

[Jonas Ådahl]

On Thu, Aug 17, 2017 at 05:05:35PM +0200, Marco Martin wrote:
> On Thu, Aug 10, 2017 at 3:47 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
> >
> > Anyhow, "export_surface" or maybe even "export_toplevel" (as that is the only
> > thing we allow exporting anyway) seems fine to me. The "import" request
> > should be renamed in a similar manner as well then.
> 
> here attached a patch to rename the calls to export_toplevel and
> import_toplevel, is that ok?

You'll need to create an "unstable v2" version, as this is a
non-backward compatible change. To do that, copy the XML file, changing
the v1 to v2 - then make the change. Some comments inline below too:

> 
> --
> Marco Martin

> From 79a050a0a22cb9f04d7679fe2fcd28e797e6957c Mon Sep 17 00:00:00 2001
> From: Marco Martin <notmart at gmail.com>
> Date: Thu, 17 Aug 2017 16:58:33 +0200
> Subject: [PATCH] rename export and import calls
> 
> as export is a reserved keyword in C++, in order for the
> output generated by wayland_scanner to compile correctly
> rename export to export_toplevel and import to import_toplevel
> 
> Signed-off-by: Marco Martin <notmart at gmail.com>
> ---
>  unstable/xdg-foreign/xdg-foreign-unstable-v1.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/unstable/xdg-foreign/xdg-foreign-unstable-v1.xml b/unstable/xdg-foreign/xdg-foreign-unstable-v1.xml
> index 062b090..6d5e1f1 100644
> --- a/unstable/xdg-foreign/xdg-foreign-unstable-v1.xml
> +++ b/unstable/xdg-foreign/xdg-foreign-unstable-v1.xml
> @@ -69,7 +69,7 @@
>        </description>
>      </request>
>  
> -    <request name="export">
> +    <request name="export_toplevel">

Would be good to adapt the text below (and in import too) to reflect
this change.


Jonas

>        <description summary="export a surface">
>  	The export request exports the passed surface so that it can later be
>  	imported via xdg_importer. When called, a new xdg_exported object will
> @@ -101,7 +101,7 @@
>        </description>
>      </request>
>  
> -    <request name="import">
> +    <request name="import_toplevel">
>        <description summary="import a surface">
>  	The import request imports a surface from any client given a handle
>  	retrieved by exporting said surface using xdg_exporter.export. When
> -- 
> 2.7.4
>