[PATCH weston 2/2] weston: add --device option for DRM-backend

Daniel Stone daniel at fooishbar.org
Mon Dec 4 20:02:48 UTC 2017


Hi Pekka,

On 28 March 2017 at 16:26, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> Developers with testing rigs having multiple graphics cards plugged in
> often want to test things on a specific card. We have ways to choose a
> card through seat assignments, but configuring that run by run is
> awkward.
>
> Add a command line option for opening a specific DRM device.
>
> [...]
>
> --- a/compositor/main.c
> +++ b/compositor/main.c
> @@ -565,6 +565,7 @@ usage(int error_code)
>                 "  --connector=ID\tBring up only this connector\n"
>                 "  --seat=SEAT\t\tThe seat that weston should run on\n"
>                 "  --tty=TTY\t\tThe tty to use\n"
> +               "  --device=CARD\t\tThe DRM device to use, e.g. \"card0\".\n"
>                 "  --use-pixman\t\tUse the pixman (CPU) renderer\n"
>                 "  --current-mode\tPrefer current KMS mode over EDID preferred mode\n\n");
>  #endif
> @@ -1225,6 +1226,7 @@ load_drm_backend(struct weston_compositor *c,
>                 { WESTON_OPTION_INTEGER, "connector", 0, &config.connector },
>                 { WESTON_OPTION_STRING, "seat", 0, &config.seat_id },
>                 { WESTON_OPTION_INTEGER, "tty", 0, &config.tty },
> +               { WESTON_OPTION_STRING, "device", 0, &config.specific_device },

Please can we call it --drm-device instead? With that, the two are:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list