[PATCH weston] compositor-drm: reset KMS state on VT-switch in

Daniel Stone daniel at fooishbar.org
Thu Jul 27 10:54:43 UTC 2017


Hi,

On 27 July 2017 at 11:51, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> @@ -2810,6 +2820,7 @@ create_output_for_connector(struct drm_backend *b,
>         if (output == NULL)
>                 goto err;
>
> +       output->state_invalid = true;
>         output->connector = connector;
>         output->crtc_id = resources->crtcs[i];
>         output->pipe = i;
> @@ -3130,6 +3141,10 @@ session_notify(struct wl_listener *listener, void *data)
>                 weston_log("activating session\n");
>                 weston_compositor_wake(compositor);
>                 weston_compositor_damage_all(compositor);
> +
> +               wl_list_for_each(output, &compositor->output_list, base.link)
> +                       output->state_invalid = true;
> +

In addition to output creation, and on VT enter, should we also be
resetting the state on output enable? Or maybe just moving it there
from create_output_for_connector, rather than both. Either way:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list