[PATCH wayland-protocols] xdg-output: add a transform example for the logical size

Simon Ser contact at emersion.fr
Mon Jul 16 18:45:11 UTC 2018


Hi Jonas,

What do you think of this patch?

Thanks,

Simon

On July 9, 2018 3:25 PM, Olivier Fourdan <fourdan at gmail.com> wrote:
> Hi,
>
> On Mon, 9 Jul 2018 at 11:09, Simon Ser <contact at emersion.fr> wrote:
> >
> > Bump: this is the source of bugs in xwayland [1].
> >
> > [1]: https://lists.x.org/archives/xorg-devel/2018-July/057285.html
> >
> > On May 18, 2018 9:40 PM, Simon Ser <contact at emersion.fr> wrote:
> > > Signed-off-by: Simon Ser <contact at emersion.fr>
> > > ---
> > >
> > > I believe it's easy to understand that transformations are not applied to
> > > the logical size.
> > >
> > >  unstable/xdg-output/xdg-output-unstable-v1.xml | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/unstable/xdg-output/xdg-output-unstable-v1.xml b/unstable/xdg-output/xdg-output-unstable-v1.xml
> > > index bd9a8a8..320c0a0 100644
> > > --- a/unstable/xdg-output/xdg-output-unstable-v1.xml
> > > +++ b/unstable/xdg-output/xdg-output-unstable-v1.xml
> > > @@ -135,6 +135,9 @@
> > >       - A compositor using a fractional scale of 1.5 will advertise a
> > >         logical size to 2560×1620.
> > >
> > > +     For example, for a wl_output mode 1920×1080 and a 90 degree rotation, the
> > > +     compositor will advertise a logical size of 1080x1920.
> > > +
> > >       The logical_size event is sent after creating an xdg_output
> > >       (see xdg_output_manager.get_xdg_output) and whenever the logical
> > >       size of the output changes, either as a result of a change in the
> > > --
> > > 2.17.0
>
> Reviewed-by: Olivier Fourdan <ofourdan at redhat.com>
>
> That r-b doesn't apply to the Xwayland patch though, to which I 'll
> reply in the relevant thread.
>
> Cheers,
> Olivier



More information about the wayland-devel mailing list