[RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

Jasper St. Pierre jstpierre at mecheye.net
Thu Jul 26 02:52:53 UTC 2018


Hi,

>From IRC conversations with krh a long time ago, this is indeed intentional
and the cursor surface should "lose its role" in modern parlance.

The original intention was to prevent glitching of the cursor surface. e.g.
If the left side of the surface has a resize left cursor, you leave, and
hover over the right, you don't want to see the resize left cursor for a
split second before the resize right cursor appears.

The original implementation of Weston respected this and would only change
the cursor on set_cursor calls and would not even remember a per-client
cursor surface. This behavior has probably been lost in numerous reactors
by now.

On Tue, Jul 24, 2018, 2:52 PM Daniel Stone <daniel at fooishbar.org> wrote:

> Hey,
>
> On Tue, 24 Jul 2018 at 22:45, Derek Foreman
> <derek.foreman.samsung at gmail.com> wrote:
> > On 2018-07-22 05:55 AM, Daniel Stone wrote:
> > > I take it the problem is that the client sets a particular surface as
> > > the pointer surface, loses focus, sets the same surface as the pointer
> > > surface on re-enter after not changing the content, and then the
> > > content is never shown?
> >
> > That's my understanding of what I'm seeing, yes.
> >
> > Note that it only happens when the cursor can be placed in the cursor
> > plane (ie: it's wayland_shm).
> >
> > The old cursor continues to be shown - if I move into an EFL client from
> > the desktop, the desktop cursor arrow is sometimes unchanged.
> >
> > I do get a surface enter for my pointer surface, though.
> >
> > I'm reasonably confident the first time I saw this I would get no cursor
> > at all on re-enter, but now I get the existing cursor.  Though sometimes
> > it updates to my client cursor, despite no damage or new buffer attach
> > on the surface.
>
> To be fair, this has changed a fair bit with atomic, so I'm not
> surprised it's different in master. But I am a bit disappointed it's
> not perfect yet. ;)
>
> Cheers,
> Daniel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180725/6312ba49/attachment-0001.html>


More information about the wayland-devel mailing list