[PATCH weston 4/4] tests: Reshuffle IVI layout tests

Pekka Paalanen ppaalanen at gmail.com
Wed Jun 20 11:19:56 UTC 2018


On Tue, 19 Jun 2018 18:39:09 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 18 June 2018 at 15:40, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > From: Daniel Stone <daniels at collabora.com>
> >
> > Rename the IVI tests to be more consistent with the others, and invert
> > the naming of plugin/client to make it slightly more clear what's going
> > to happen. Handle the renaming by using wet_get_binary_path to rewrite
> > the local binaries.
> >
> > As a side-effect, weston.ini ivi-shell-user-interface no longer needs to
> > be given as an absolute path.
> >
> > Signed-off-by: Daniel Stone <daniels at collabora.com>
> >
> > v2:
> >
> > Call ivi-layout.ivi as ivi-layout-test-client.ivi to keep the same name
> > in both the file and the lookup, so that the module map does not need to
> > change the name.
> >
> > Update code comments to reflect the new names.
> >
> > Rename ivi_layout-test-plugin.c to ivi-layout-test-plugin.c.
> >  
> About half of the patch is the mechanical rename - worth keeping that
> separate from the rest?

True, it would be better that way, but if you don't insist, I won't
bother, since three people with you included have already reviewed the
patch.

> Either way, patch looks spot on and is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Cheers,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180620/170a7bda/attachment.sig>


More information about the wayland-devel mailing list