compositor: do not free output region twice in weston_output_set_transform()

Pekka Paalanen ppaalanen at gmail.com
Fri Mar 16 10:31:46 UTC 2018


On Wed, 14 Mar 2018 10:59:52 +0200
Ilia Bozhinov <ammen99 at gmail.com> wrote:

> This is already done when weston_output_init_geometry() is called.
> Actually this is a fix for 8564a0d, because without this patch, the
> compositor sometimes crashes when setting output transform
> 
> Signed-off-by: Ilia Bozhinov <ammen99 at gmail.com>
> ---
>  libweston/compositor.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/libweston/compositor.c b/libweston/compositor.c
> index aec937bb..0079c848 100644
> --- a/libweston/compositor.c
> +++ b/libweston/compositor.c
> @@ -4705,9 +4705,6 @@ weston_output_set_transform(struct weston_output *output,
>  	pixman_region32_init(&old_region);
>  	pixman_region32_copy(&old_region, &output->region);
>  
> -	pixman_region32_fini(&output->region);
> -	pixman_region32_fini(&output->previous_damage);
> -
>  	weston_output_init_geometry(output, output->x, output->y);
>  
>  	output->dirty = 1;

Looks good, pushed:
   5fa19343..6dba368a  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180316/136ae995/attachment.sig>


More information about the wayland-devel mailing list