Well, with your patch it doesn't seem to crash. There is also no list corruption, as far as I could test it :)<div><br></div><div>Regards,</div><div>Iskren<br><br><div class="gmail_quote">2011/3/13 Kristian Høgsberg <span dir="ltr"><<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">On Fri, Mar 11, 2011 at 7:32 PM, Iskren Chernev<br>
<div class="im"><<a href="mailto:iskren.chernev@gmail.com">iskren.chernev@gmail.com</a>> wrote:<br>
</div><div class="im">> Hello,<br>
> I found a bug and fixed it with the patch :)<br>
> to reproduce:<br>
<br>
</div>Hi,<br>
<br>
I wasn't able to reproduce it immediately, but I know that there's a<br>
crasher in there somewhere. I think the real fix is the patch I've<br>
attached, could you give it a try and see if it fixes it for you?<br>
<br>
thanks,<br>
<font color="#888888">Kristian<br>
</font><div><div></div><div class="h5"><br>
> run compositor on top of x11<br>
> repeat<br>
> run flower<br>
> drag & drop it a little<br>
> move the pointer in and out of the compositor/flower<br>
> Ctrl+C the flower client<br>
> it would break eventually<br>
> problem:<br>
> I found that the linked list surface->destroy_listener_list got corrupted at<br>
> some point (it was not circular any more, strange next/prev etc), which<br>
> causes the crash.<br>
> solution:<br>
> The problem was in wl_list_remove -- when you erase an element, you don't<br>
> mark it as 'erased', by setting prev/next to NULL for example. Then if you<br>
> erase it again the list becomes corrupt. I nullified the prev/next and check<br>
> in the begining of wl_list_remove for not-in-list elements and just ignore<br>
> them. That seems to fix it.<br>
> Regards,<br>
> Iskren<br>
</div></div><div><div></div><div class="h5">> _______________________________________________<br>
> wayland-devel mailing list<br>
> <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>