<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=ProgId content=Word.Document><meta name=Generator content="Microsoft Word 12"><meta name=Originator content="Microsoft Word 12"><link rel=File-List href="cid:filelist.xml@01CC97C6.91B94A20"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='tab-interval:21.0pt;text-justify-trim:punctuation'><div class=WordSection1>After understanding the process of wl_client_connection_data->wl_closure_invoke->shell_set_toplevel, some solution for this problem is found: we need check the object type before taking actions in shell_set_toplevel.<o:p></o:p><o:p> </o:p>Since the clients send the request to the server that “please let the item 9 in wl_map object do shell_set_toplevel”. In fact, the item 9 in wl_map is wl_buffer object. But shell_set_toplevel’s parameter only treated it as wl_surface. So there is segment fault and random errors.<o:p></o:p>The solution can be checking the interface name before doing operations, like this:<o:p></o:p>        if((struct wl_interface *)(((struct wl_object *)surface_resource)->interface)->name!="wl_surface")<o:p></o:p>        {<o:p></o:p>                printf("set wl_buffer to the toplevel in shell_set_toplevel, return!");<o:p></o:p>                return;<o:p></o:p>        }<o:p></o:p>By the way, the boundary check for the damage is also necessary.<o:p></o:p><o:p> </o:p>With this solution, “simple” in gtk application can run OK with wayland compositor with X11 backend.<o:p></o:p>Any other suggestions?<o:p></o:p>If no, I will send out the patch later.<o:p></o:p><o:p> </o:p><o:p> </o:p>-----<o:p></o:p>*^_^* BRs,<o:p></o:p>Juan<o:p></o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: Zhao, Juan J Sent: Friday, October 28, 2011 8:19 PM To: wayland-devel@lists.freedesktop.org Subject: RE: questions about gtk simple applications running on wayland<o:p></o:p></div></div><o:p> </o:p>Updates today:<o:p></o:p>In the client side: Gtk call wl_egl_pixmap_create_buffer to create the buffer and then use wl_surface_attach to attach this buffer to its surface.<o:p></o:p>In the server side: drm_create_buffer is called and add that buffer resource to this client. And wl_map_insert_at will be called. That buffer resource is inserted to the map. Then surface_attach will be called, this buffer will be saved to one wlsc_surface.<o:p></o:p><o:p> </o:p>Then in the client side, gtk call wl_shell_set_toplevel, wl_connection_vmarshal will be called. <o:p></o:p>In the server side, shell_set_toplevel is called. The third parameter is the previous buffer object created by drm_create_buffer not the wlsc_surface.<o:p></o:p>Should I need to look into wl_connection_vmarshal to check each parameter sent to the server?<o:p></o:p><o:p> </o:p>-----<o:p></o:p>*^_^* BRs,<o:p></o:p>Juan<o:p></o:p><o:p> </o:p><o:p> </o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: Zhao, Juan J Sent: Thursday, October 27, 2011 4:15 PM To: Zhao, Juan J; wayland-devel@lists.freedesktop.org Subject: RE: questions about gtk simple applications running on wayland<o:p></o:p></div></div><o:p> </o:p>Some updates for this question.<o:p></o:p>In gtk side, if I run “wl_shell_set_toplevel” once the surface is created by “wl_compositor_create_surface”, everything is OK.<o:p></o:p>But later, gtk application will bind some image to this surface. And then call “wl_shell_set_toplevel”.<o:p></o:p><o:p> </o:p>In the server side, the function shell_set_toplevel’s third parameter is only “wl_buffer” but not “wlsc_surface”.<o:p></o:p>The server used some point which is not for wlsc_surface, and then, random result shows: like the height and width is too big….<o:p></o:p>Any thoughts?<o:p></o:p><o:p> </o:p>-----<o:p></o:p>*^_^* BRs,<o:p></o:p>Juan<o:p></o:p><o:p> </o:p><o:p> </o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: wayland-devel-bounces+juan.j.zhao=intel.com@lists.freedesktop.org [mailto:wayland-devel-bounces+juan.j.zhao=intel.com@lists.freedesktop.org] On Behalf Of Zhao, Juan J Sent: Thursday, October 27, 2011 9:26 AM To: wayland-devel@lists.freedesktop.org Subject: questions about gtk simple applications running on wayland<o:p></o:p></div></div><o:p> </o:p>Hey there,<o:p></o:p>  These days, I’m trying to run some simple gtk applications on wayland.<o:p></o:p>  I built gtk, and fix some mismatched wayland interface. But there are still some problems.<o:p></o:p>  It is announced that gtk applications can run on X11 backend wayland compositor. So I choose this backend at first.<o:p></o:p>  Simple wayland client demos can run OK. But when running gtk applications, I will find that server will meet segment fault.<o:p></o:p>  The segment fault is directly caused by shell_set_toplevel->wlsc_surface_damage->wlsc_surface_damage_rectangle->pixman_region32_union_rect. The width and height is more than 10,000+. <o:p></o:p>  Looks like some boundaries check should be added here. Because the server should not crashed by some unhealthy clients. <o:p></o:p>And maybe we can still send some message to the client:”Hey, you did something wrong…and I will ignore your request”<o:p></o:p>  <o:p></o:p>Obviously, this is not the root cause. I went on track the shell_top_level’s resource. This resource is inserted to wl_map by bind_shell.<o:p></o:p>There are something strange here. When adding these resource, it is a kind of wl_shell resource. But when using it in shell_set_toplevel, it become a wlsc_surface resource….<o:p></o:p>Did I misunderstand something here? Any thoughts for me for going ahead to fix this problem to the root cause?<o:p></o:p><o:p> </o:p><o:p> </o:p><o:p> </o:p>-----<o:p></o:p>*^_^* BRs,<o:p></o:p>Juan<o:p></o:p><o:p> </o:p><o:p> </o:p></div></div></div></div></body></html>