Wouldn't this be simpler?<div> </div><div>snprintf(path, sizeof path, "%s/%s", MODULEDIR, name);</div><div> <div class="gmail_quote">On Wed, May 23, 2012 at 11:32 PM, Chad Versace <<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If the MODULEDIR string contains '%', then snprintf(path, sizeof(path), MODULEDIR "/%s", name); does not do what you want. Fix this by replacing snprintf with stncpy followed by strncat. Signed-off-by: Chad Versace <<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>> --- src/compositor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 3c1e058..e556e70 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -2773,10 +2773,12 @@ load_module(const char *name, const char *entrypoint, void **handle) char path[PATH_MAX]; void *module, *init; - if (name[0] != '/') - snprintf(path, sizeof path, MODULEDIR "/%s", name); - else + if (name[0] != '/') { + strncpy(path, MODULEDIR "/", sizeof(path) - 1); + strncat(path, name, sizeof(path) - sizeof(MODULEDIR "/") - 1); + } else { snprintf(path, sizeof path, "%s", name); + } module = dlopen(path, RTLD_LAZY); if (!module) { -- 1.7.10.2 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div>