<div class="gmail_quote">On Thu, May 31, 2012 at 11:10 AM, Kristian Høgsberg <<a href="mailto:hoegsberg@gmail.com" target="_blank">hoegsberg@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im">On Sun, May 27, 2012 at 02:25:02PM -0600, Scott Moreau wrote: > Here we create a new client/compositor interface in weston to allow > clients to report their x/y cursor position to the compositor. These > values are then used to center the zoom area on this point. This > is useful for everyone, especially people who are visually impaired. > --- > > Made changes discussed for v3 patch. </div>Committed as is, but just a brief comment below. Kristian </blockquote><div class="h5"> Thanks! > > @@ -72,6 +73,7 @@ struct display { > struct wl_shell *shell; > struct wl_shm *shm; > struct wl_data_device_manager *data_device_manager; > + struct text_cursor_position *text_cursor_position; > EGLDisplay dpy; > EGLConfig argb_config; > EGLContext argb_ctx; > @@ -149,6 +151,7 @@ struct window { > int resize_needed; > int type; > int transparent; > + int send_cursor_position; > struct input *keyboard_device; > enum window_buffer_type buffer_type; > > @@ -1822,6 +1825,9 @@ keyboard_handle_key(void *data, struct wl_keyboard *keyboard, > if (!window || window->keyboard_device != input) > return; > > + if (state) > + window->send_cursor_position = 1; > + </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I don't think we should track this in window.c. If a client wants to set the text cursor position, we shouldn't second guess it. Maybe the cursor is moving because text got pasted into the window or such. </blockquote><div> Ok, I'm a little confused about this then. Here, <a href="http://lists.freedesktop.org/archives/wayland-devel/2012-May/003597.html">http://lists.freedesktop.org/archives/wayland-devel/2012-May/003597.html</a> you made this comment: "Shouldn't we only update position when the user actually presses a key? What if you're dumping a lot of data to the terminal?" This is the only reason I even installed this additional code. Thanks, Scott </div></div>