<br><br><div class="gmail_quote">On Mon, Sep 10, 2012 at 5:02 AM, Ander Conselvan de Oliveira <span dir="ltr"><<a href="mailto:conselvan2@gmail.com" target="_blank">conselvan2@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Scott,<br>
<br>
Thanks for reviewing!<div class="im"><br>
<br>
On 09/07/2012 11:23 PM, Scott Moreau wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
<br>
On Fri, Sep 7, 2012 at 7:32 AM, Ander Conselvan de Oliveira<br></div><div class="im">
<<a href="mailto:conselvan2@gmail.com" target="_blank">conselvan2@gmail.com</a> <mailto:<a href="mailto:conselvan2@gmail.com" target="_blank">conselvan2@gmail.com</a>>> wrote:<br>
<br>
Since commit d523a87d2d8c0099d8ac323375b3d0<u></u>83aafccf9a [1],<br>
<br>
<br>
I'm not sure where you got this sha from but it's wrong. There is no<br>
such commit in weston.<br>
</div></blockquote>
<br>
My mistake. I had a rebased branch with one extra commit that I used for bisecting and forgot to change to master before doing this.<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
window.opaque<br>
would be 1 only in fullscreen mode, causing the opaque region to be set<br>
only when running in fullscreen mode. Having it set properly for the<br>
windowed case is helpful to test the overlay path in compositor-drm.<br>
<br>
This reverts that commit and makes window.opaque independent of the -f<br>
switch. Instead, we set the opaque region if the window is fullscreen<br>
or -o was passed and leave window.opaque alone in the case -f was<br>
passed.<br>
<br>
<br>
Did you read the entire commit message? It seems you have cut it here so<br>
I will post it:<br>
</blockquote>
<br></div>
I did. And it seems I forgot to mention in the commit message that this patch does not regress the bug solved in said commit, it just, IMO, a better fix for the problem.<br>
<br>
[...]<div class="im"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm not sure what you're trying to do with your patches here but please<br>
note the problem that this commit fixed and do not break it.<br>
</blockquote>
<br></div>
What I'm trying to do here is have the opaque region of the simple-egl surface set properly when it is run with the -o switch, even when not running fullscreen. That setup uncovered a bug where too much redrawing was culled when using overlays.<br>
<br>
I guess I created this whole mess because when I added fullscreen support I made it use an XRGB config to test the scanning out of client buffers. The "if (fullscreen) opaque = 1;" conditional survived this far, but since the introduction of '-o' it shouldn't be needed anymore. (Well, the compositor should know that a fullscreen surface is opaque anyway, but that's a different story.)<br>
<br>
So what this patch does is:<br>
<br>
- reverts your patch;<br>
- removes the if fullscreen make the window opaque switch, which fixes the problem of getting an opaque window if simple-egl is launched with -f and later made not fullscreen;<br>
- sets the opaque region in redraw() also when in fullscreen mode, regardless of the -o switch, so the compositor still scans out the client buffers in that case.<br>
<br>
Anyway, I'll resend the patch with the correct sha1 of the commit and try to be clearer about what the patch does.<br>
<br>
Thanks,<br>
Ander<br></blockquote><div><br><br>That makes it much clearer, thanks for explaining. This seems like the better fix.<br><br>Scott <br></div></div><br>