<br><br><div class="gmail_quote">On Thu, Sep 27, 2012 at 11:04 AM, Jonas Ådahl <span dir="ltr"><<a href="mailto:jadahl@gmail.com" target="_blank">jadahl@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">Signed-off-by: Jonas Ådahl <<a href="mailto:jadahl@gmail.com">jadahl@gmail.com</a>><br>
---<br>
</div> src/shell.c |    7 ++++---<br>
<div class="im"> 1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/shell.c b/src/shell.c<br>
</div>index e2715d6..6193bd2 100644<br>
--- a/src/shell.c<br>
+++ b/src/shell.c<br>
@@ -2361,7 +2361,7 @@ static void<br>
<div class="im"> surface_opacity_binding(struct wl_seat *seat, uint32_t time, uint32_t axis,<br>
                        wl_fixed_t value, void *data)<br>
 {<br>
-       float step = 0.05;<br>
+       float step = 0.005;<br>
        struct shell_surface *shsurf;<br>
        struct weston_surface *surface =<br>
                (struct weston_surface *) seat->pointer->focus;<br>
</div>@@ -2373,7 +2373,7 @@ surface_opacity_binding(struct wl_seat *seat, uint32_t time, uint32_t axis,<br>
<div class="im">        if (!shsurf)<br>
                return;<br>
<br>
-       surface->alpha += wl_fixed_to_double(value) * step;<br>
+       surface->alpha -= wl_fixed_to_double(value) * step;<br>
<br>
        if (surface->alpha > 1.0)<br>
                surface->alpha = 1.0;<br>
</div>@@ -2403,8 +2403,9 @@ do_zoom(struct wl_seat *seat, uint32_t time, uint32_t key, uint32_t axis,<br>
<div class="HOEnZb"><div class="h5">                        else if (key == KEY_PAGEDOWN)<br>
                                increment = -output->zoom.increment;<br>
                        else if (axis == WL_POINTER_AXIS_VERTICAL_SCROLL)<br>
+                               /* For every pixel zoom 20th of a step */<br>
                                increment = output->zoom.increment *<br>
-                                           wl_fixed_to_double(value);<br>
+                                           -wl_fixed_to_double(value) / 20.0;<br>
                        else<br>
                                increment = 0;<br>
<br>
--<br>
1.7.9.5<br><br></div></div></blockquote><div><br>This patch effectively breaks surface_opacity_binding for the desktop mouse case. It reverses the order and makes the increment far too small. Maybe if you can explain what you are trying to do here, we can find a solution that doesn't break the current behaviour.<br>
<br><br><br>Scott<br></div></div><br>