<br><br><div class="gmail_quote">On Fri, Mar 8, 2013 at 1:05 PM, Philipp Brüschweiler <span dir="ltr"><<a href="mailto:blei42@gmail.com" target="_blank">blei42@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Sorry, forgot Reply All.<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 8, 2013 at 9:04 PM, Philipp Brüschweiler <span dir="ltr"><<a href="mailto:blei42@gmail.com" target="_blank">blei42@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Fri, Mar 8, 2013 at 8:44 PM, Scott Moreau <span dir="ltr"><<a href="mailto:oreaus@gmail.com" target="_blank">oreaus@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote"><div>On Fri, Mar 8, 2013 at 12:35 PM, Philipp Brüschweiler <span dir="ltr"><<a href="mailto:blei42@gmail.com" target="_blank">blei42@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Fixes <a href="https://bugs.freedesktop.org/show_bug.cgi?id=61930" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=61930</a><br>
---<br>
src/pixman-renderer.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c<br>
index 9571f6f..9dbe9f0 100644<br>
--- a/src/pixman-renderer.c<br>
+++ b/src/pixman-renderer.c<br>
@@ -485,6 +485,8 @@ pixman_renderer_init(struct weston_compositor *ec)<br>
if (renderer == NULL)<br>
return -1;<br>
<br>
+ renderer->repaint_debug = 0;<br>
+ renderer->debug_color = NULL;<br></blockquote></div><div><br>Alternatively you could change malloc to calloc so the entire struct is initialized.<br></div></div></blockquote><div><br></div></div><div>True. Though this has the downside that valgrind will not be able to tell you when you are using uninitialized memory. Which is a pretty small downside compared to this bug. What is the general convention in wayland/weston regarding malloc vs. calloc?<br>
</div></div></div></div></blockquote></div></div></div></div></blockquote><div><br>I think there are enough instances in the code to answer this question.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">
<div class="gmail_quote"><div>
</div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
renderer->base.read_pixels = pixman_renderer_read_pixels;<br>
renderer->base.repaint_output = pixman_renderer_repaint_output;<br>
renderer->base.flush_damage = pixman_renderer_flush_damage;<br>
</div><span><font color="#888888"><span><font color="#888888">--<br>
1.8.1.5<br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org" target="_blank">wayland-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</font></span></font></span></blockquote></div><br>
</blockquote></div></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br>