We talked about this on IRC. looks good to me. <div class="gmail_quote">On Jul 10, 2013 4:42 PM, "Mariusz Ceier" <<a href="mailto:mceier%2Bwayland@gmail.com">mceier+wayland@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Functions like wl_argument_from_va_list expect from get_next_argument, to initialize details->type but when the signature is empty or contains only version (like in desktop-shell-protocol.c in weston) it is left uninitialized. This patch fixes it, by initializing details->type with '\0' value, signaling end of arguments. Signed-off-by: Mariusz Ceier <<a href="mailto:mceier%2Bwayland@gmail.com">mceier+wayland@gmail.com</a>> --- src/connection.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/connection.c b/src/connection.c index 2ca9bce..9bb850c 100644 --- a/src/connection.c +++ b/src/connection.c @@ -419,6 +419,7 @@ get_next_argument(const char *signature, struct argument_details *details) details->nullable = 1; } } + details->type = '\0'; return signature; } -- 1.8.3.2 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div>