<div dir="ltr"><div>*bump* This one came up on IRC again the other day. </div>--Jason Ekstrand </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Apr 9, 2013 at 4:59 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Valgrind complains because sometimes padding at the ends of strings and arrays is left uninitialized. Zeroing out the buffer fixes this problem. Signed-off-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> --- src/connection.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/connection.c b/src/connection.c index 9425ca6..f79b6d0 100644 --- a/src/connection.c +++ b/src/connection.c @@ -1018,6 +1018,8 @@ wl_closure_send(struct wl_closure *closure, struct wl_connection *connection) uint32_t buffer[256]; int size; + memset(buffer, 0, sizeof buffer); + if (copy_fds_to_connection(closure, connection)) return -1; @@ -1034,6 +1036,8 @@ wl_closure_queue(struct wl_closure *closure, struct wl_connection *connection) uint32_t buffer[256]; int size; + memset(buffer, 0, sizeof buffer); + if (copy_fds_to_connection(closure, connection)) return -1; -- 1.8.1.4 </blockquote></div> </div>