<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">You are right, but if we use the slide
effect, the target value has no meaning for alpha.<br>
The only time we use the fade effect with a target alpha value of
0 is the shell_fade effect with the FADE_IN parameter: at the end
the surface is destroyed anyway.<br>
<br>
I think however the first patch was better, but I should add too
to set surface->alpha to 1.0 for the shell_fade effect and the
FADE_OUT parameter.<br>
<br>
Kristian, what do you like better?<br>
<br>
Axel Davy<br>
<br>
<br>
Le 12/09/2013 10:27, Giulio Camuffo a écrit :<br>
</div>
<blockquote
cite="mid:CAERs7a8m2kVLxf-29ZkC3nyQSW6Tswb=m2bVkjDLGNi2h-JNfQ@mail.gmail.com"
type="cite">
<div dir="ltr">Shouldn't this set the alpha to the target alpha
instead of 1? What if i fade from 1 to 0, this will set it back
to 1 when it's done.</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/9/12 Axel Davy <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:axel.davy@ens.fr"
target="_blank">axel.davy@ens.fr</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">After the
fade or zoom effects, alpha could not have been 1.0,
preventing<br>
not redrawing behind opaque windows.<br>
<br>
Signed-off-by: Axel Davy <<a moz-do-not-send="true"
href="mailto:axel.davy@ens.fr">axel.davy@ens.fr</a>><br>
---<br>
src/animation.c | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/src/animation.c b/src/animation.c<br>
index 0b2fa95..9603115 100644<br>
--- a/src/animation.c<br>
+++ b/src/animation.c<br>
@@ -134,6 +134,7 @@ weston_surface_animation_destroy(struct
weston_surface_animation *animation)<br>
wl_list_remove(&animation->animation.link);<br>
wl_list_remove(&animation->listener.link);<br>
wl_list_remove(&animation->transform.link);<br>
+ animation->surface->alpha = 1.0;<br>
weston_surface_geometry_dirty(animation->surface);<br>
if (animation->done)<br>
animation->done(animation,
animation->data);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.2<br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a moz-do-not-send="true"
href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
<a moz-do-not-send="true"
href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel"
target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>