<div dir="ltr">You're right, your fix does look better!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 15, 2013 at 5:07 AM, Axel Davy <span dir="ltr"><<a href="mailto:davy@clipper.ens.fr" target="_blank">davy@clipper.ens.fr</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    <div>I've posted a patch, which prevents
      wm->focus_window to be a window without frame.<br>
      <br>
      This solves the same bug than this patch, but looks better to me.<br>
      <br>
      
      <a href="http://lists.freedesktop.org/archives/wayland-devel/2013-November/012008.html" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2013-November/012008.html</a><br>
      <br>
      Axel Davy<br>
      <br>
      Le 15/11/2013 11:25, Axel Davy a écrit :<br>
    </div>
    <blockquote type="cite"><div><div class="h5">This
      patch (Again, I had the same), solves the last bugs for XWayland,
      <br>
      but for this one, I'm not sure it is the correct fix.
      <br>
      <br>
      In fact it would mean than focus_window would be an unmapped
      windows,
      <br>
      which looks strange to me.
      <br>
      <br>
      Axel Davy
      <br>
      <br>
      Le 15/11/2013 11:01, Dima Ryazanov a écrit :
      <br>
      <blockquote type="cite">Fixes a crash in Firefox when clicking an
        "install plugin" popup.
        <br>
        <br>
        Signed-off-by: Dima Ryazanov <a href="mailto:dima@gmail.com" target="_blank"><dima@gmail.com></a>
        <br>
        ---
        <br>
          src/xwayland/window-manager.c | 6 ++++--
        <br>
          1 file changed, 4 insertions(+), 2 deletions(-)
        <br>
        <br>
        diff --git a/src/xwayland/window-manager.c
        b/src/xwayland/window-manager.c
        <br>
        index 5ee9480..6d29026 100644
        <br>
        --- a/src/xwayland/window-manager.c
        <br>
        +++ b/src/xwayland/window-manager.c
        <br>
        @@ -695,12 +695,14 @@ weston_wm_window_activate(struct
        wl_listener *listener, void *data)
        <br>
              }
        <br>
                if (wm->focus_window) {
        <br>
        -        frame_unset_flag(wm->focus_window->frame,
        FRAME_FLAG_ACTIVE);
        <br>
        +        if (wm->focus_window->frame)
        <br>
        +            frame_unset_flag(wm->focus_window->frame,
        FRAME_FLAG_ACTIVE);
        <br>
                 
        weston_wm_window_schedule_repaint(wm->focus_window);
        <br>
              }
        <br>
              wm->focus_window = window;
        <br>
              if (wm->focus_window) {
        <br>
        -        frame_set_flag(wm->focus_window->frame,
        FRAME_FLAG_ACTIVE);
        <br>
        +        if (wm->focus_window->frame)
        <br>
        +            frame_set_flag(wm->focus_window->frame,
        FRAME_FLAG_ACTIVE);
        <br>
                 
        weston_wm_window_schedule_repaint(wm->focus_window);
        <br>
              }
        <br>
          }
        <br>
      </blockquote>
      <br></div></div>
      _______________________________________________
      <br>
      wayland-devel mailing list
      <br>
      <a href="mailto:wayland-devel@lists.freedesktop.org" target="_blank">wayland-devel@lists.freedesktop.org</a>
      <br>
      <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a>
      <br>
      <br>
    </blockquote>
    <br>
  </div>

</blockquote></div><br></div>