<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I have tested your patch, but it
doesn't solve all the bugs occuring in XWayland because of views
(take vlc, go to the menu, crash). <br>
<br>
It appears ok to me to set view to NULL at these locations, but
there's probably something more to do.<br>
<br>
Axel Davy<br>
<br>
On 15/11/2013, Dima Ryazanov wrote :<br>
</div>
<blockquote
cite="mid:CA++2Deojucbvn8gcPK+8H54Hui8P_BFZdUYY3L3eyaGdxT902w@mail.gmail.com"
type="cite">
<div dir="ltr">Ping :)</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Nov 1, 2013 at 12:46 AM, Dima
Ryazanov <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:dima@gmail.com" target="_blank">dima@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Fixes a
crash caused by accessing a deleted view in
weston_wm_window_schedule_repaint. It can be easily
reproduced by switching between menus in Firefox.<br>
<br>
Signed-off-by: Dima Ryazanov <<a moz-do-not-send="true"
href="mailto:dima@gmail.com">dima@gmail.com</a>><br>
---<br>
src/xwayland/window-manager.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/xwayland/window-manager.c
b/src/xwayland/window-manager.c<br>
index b2776a0..5ee9480 100644<br>
--- a/src/xwayland/window-manager.c<br>
+++ b/src/xwayland/window-manager.c<br>
@@ -902,6 +902,7 @@ weston_wm_handle_unmap_notify(struct
weston_wm *wm, xcb_generic_event_t *event)<br>
wl_list_remove(&window->surface_destroy_listener.link);<br>
window->surface = NULL;<br>
window->shsurf = NULL;<br>
+ window->view = NULL;<br>
xcb_unmap_window(wm->conn, window->frame_id);<br>
}<br>
<br>
@@ -2028,6 +2029,7 @@ surface_destroy(struct wl_listener
*listener, void *data)<br>
Don't try to use it later. */<br>
window->shsurf = NULL;<br>
window->surface = NULL;<br>
+ window->view = NULL;<br>
}<br>
<br>
static struct weston_wm_window *<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.2<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
wayland-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>