<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I've posted a patch, which prevents
wm->focus_window to be a window without frame.<br>
<br>
This solves the same bug than this patch, but looks better to me.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://lists.freedesktop.org/archives/wayland-devel/2013-November/012008.html">http://lists.freedesktop.org/archives/wayland-devel/2013-November/012008.html</a><br>
<br>
Axel Davy<br>
<br>
Le 15/11/2013 11:25, Axel Davy a écrit :<br>
</div>
<blockquote cite="mid:5285F6AE.3000605@clipper.ens.fr" type="cite">This
patch (Again, I had the same), solves the last bugs for XWayland,
<br>
but for this one, I'm not sure it is the correct fix.
<br>
<br>
In fact it would mean than focus_window would be an unmapped
windows,
<br>
which looks strange to me.
<br>
<br>
Axel Davy
<br>
<br>
Le 15/11/2013 11:01, Dima Ryazanov a écrit :
<br>
<blockquote type="cite">Fixes a crash in Firefox when clicking an
"install plugin" popup.
<br>
<br>
Signed-off-by: Dima Ryazanov <a class="moz-txt-link-rfc2396E" href="mailto:dima@gmail.com"><dima@gmail.com></a>
<br>
---
<br>
src/xwayland/window-manager.c | 6 ++++--
<br>
1 file changed, 4 insertions(+), 2 deletions(-)
<br>
<br>
diff --git a/src/xwayland/window-manager.c
b/src/xwayland/window-manager.c
<br>
index 5ee9480..6d29026 100644
<br>
--- a/src/xwayland/window-manager.c
<br>
+++ b/src/xwayland/window-manager.c
<br>
@@ -695,12 +695,14 @@ weston_wm_window_activate(struct
wl_listener *listener, void *data)
<br>
}
<br>
if (wm->focus_window) {
<br>
- frame_unset_flag(wm->focus_window->frame,
FRAME_FLAG_ACTIVE);
<br>
+ if (wm->focus_window->frame)
<br>
+ frame_unset_flag(wm->focus_window->frame,
FRAME_FLAG_ACTIVE);
<br>
weston_wm_window_schedule_repaint(wm->focus_window);
<br>
}
<br>
wm->focus_window = window;
<br>
if (wm->focus_window) {
<br>
- frame_set_flag(wm->focus_window->frame,
FRAME_FLAG_ACTIVE);
<br>
+ if (wm->focus_window->frame)
<br>
+ frame_set_flag(wm->focus_window->frame,
FRAME_FLAG_ACTIVE);
<br>
weston_wm_window_schedule_repaint(wm->focus_window);
<br>
}
<br>
}
<br>
</blockquote>
<br>
_______________________________________________
<br>
wayland-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a>
<br>
<br>
</blockquote>
<br>
</body>
</html>