<div dir="ltr">Is there any reason we can't make vertex-clipping.c take floats everywhere, and adapt our code to take floats as well? I don't think GLfloat will ever be a typedef for anything but float...<br></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 19, 2013 at 4:52 PM, Emilio Pozuelo Monfort <span dir="ltr"><<a href="mailto:pochu27@gmail.com" target="_blank">pochu27@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 19/11/13 22:21, Kristian Høgsberg wrote:<br>
> On Tue, Nov 19, 2013 at 06:09:00PM +0100, Emilio Pozuelo Monfort wrote:<br>
>> And pass the right flags to build it.<br>
><br>
> This test case only uses GLfloat, we should be able to figure out a<br>
> way to compile the test with typedef float GLfloat instead.<br>
<br>
</div>We could have vertex-clipping.c have:<br>
<br>
#ifdef ENABLE_EGL<br>
#include <GLES2/gl2.h><br>
#else<br>
typedef float GLfloat;<br>
// or #define GLfloat float<br>
#endif<br>
<br>
and build/run the vertex tests unconditionally.<br>
<span class="HOEnZb"><font color="#888888"><br>
Emilio<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Kristian<br>
><br>
>> ---<br>
>> tests/Makefile.am | 9 ++++++++-<br>
>> 1 file changed, 8 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am<br>
>> index 8e08375..e123c18 100644<br>
>> --- a/tests/Makefile.am<br>
>> +++ b/tests/Makefile.am<br>
>> @@ -2,7 +2,7 @@ TESTS = $(shared_tests) $(module_tests) $(weston_tests)<br>
>><br>
>> shared_tests = \<br>
>> config-parser.test \<br>
>> - vertex-clip.test<br>
>> + $(vertex_clip_test)<br>
>><br>
>> module_tests = \<br>
>> <a href="http://surface-test.la" target="_blank">surface-test.la</a> \<br>
>> @@ -79,13 +79,20 @@ config_parser_test_LDADD = \<br>
>> $(COMPOSITOR_LIBS)<br>
>> config_parser_test_SOURCES = \<br>
>> config-parser-test.c<br>
>> +<br>
>> +if ENABLE_EGL<br>
>> +vertex_clip_test = vertex-clip.test<br>
>> vertex_clip_test_SOURCES = \<br>
>> vertex-clip-test.c \<br>
>> ../src/vertex-clipping.c \<br>
>> ../src/vertex-clipping.h<br>
>> +vertex_clip_test_CFLAGS = \<br>
>> + $(EGL_CFLAGS)<br>
>> vertex_clip_test_LDADD = \<br>
>> + $(EGL_LIBS) \<br>
>> <a href="http://libshared-test.la" target="_blank">libshared-test.la</a> \<br>
>> -lm -lrt<br>
>> +endif<br>
>><br>
>> weston_test_client_src = \<br>
>> weston-test-client-helper.c \<br>
>> --<br>
>> 1.8.4.rc3<br>
>><br>
>> _______________________________________________<br>
>> wayland-devel mailing list<br>
>> <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
>> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
><br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br> Jasper<br>
</div>