<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jason Ekstrand [mailto:jason@jlekstrand.net]
<br>
<b>Sent:</b> Saturday, March 15, 2014 9:10 PM<br>
<b>To:</b> Wang, Quanxian<br>
<b>Cc:</b> ppaalanen@gmail.com; wayland-devel@lists.freedesktop.org<br>
<b>Subject:</b> RE: [PATCH 2/3] weston:Add wl_output name event<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p><span lang="EN-US"><br>
On Mar 15, 2014 4:57 AM, "Wang, Quanxian" <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> wrote:<br>
><br>
> <br>
><br>
> <br>
><br>
> From: Jason Ekstrand [mailto:<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>]
<br>
> Sent: Saturday, March 15, 2014 3:54 AM<br>
> To: Wang, Quanxian<br>
> Cc: <a href="mailto:ppaalanen@gmail.com">ppaalanen@gmail.com</a>; <a href="mailto:wayland-devel@lists.freedesktop.org">
wayland-devel@lists.freedesktop.org</a><br>
><br>
> Subject: Re: [PATCH 2/3] weston:Add wl_output name event<br>
><br>
> <br>
><br>
><br>
> On Mar 13, 2014 9:12 PM, "Quanxian Wang" <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> wrote:<br>
> ><br>
> > Signed-off-by: Quanxian Wang <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>><br>
> > ---<br>
> > src/compositor.c | 3 +++<br>
> > 1 file changed, 3 insertions(+)<br>
> ><br>
> > diff --git a/src/compositor.c b/src/compositor.c<br>
> > index 98a4f6f..8e8964b 100644<br>
> > --- a/src/compositor.c<br>
> > +++ b/src/compositor.c<br>
> > @@ -3045,6 +3045,9 @@ bind_output(struct wl_client *client,<br>
> > }<br>
> ><br>
> > if (version >= 2)<br>
> > + wl_output_send_name(resource, output->name);<br>
><br>
> As with my comment on the protocol, wl_output_send_name should be version 3, not version 2. That should also clear up Bryce's comment.<br>
><br>
> [Wang, Quanxian] if it is 2, patch 3/3 is not needed because currently shell only support version 2. Right?<o:p></o:p></span></p>
<p><span lang="EN-US">We should still have patch 3 since weston should always support the latest version of everything.<o:p></o:p></span></p>
<p><b><i><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">[Wang, Quanxian]That is fine according to my testing. If no patch 3/3, desktop-shell will crash. I am not sure if more updates are needed. For example, in
our shell code, we use such code min(2, version) for wl_output interface, should we change it to minal(3,version) if merge this patch?</span></i></b><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<p><span lang="EN-US">><br>
> Thanks,<br>
> --Jason Ekstrand<br>
><br>
> > +<br>
> > + if (version >= 2)<br>
> > wl_output_send_done(resource);<br>
> > }<br>
> ><br>
> > --<br>
> > 1.8.1.2<br>
> ><br>
> > _______________________________________________<br>
> > wayland-devel mailing list<br>
> > <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
> > <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><o:p></o:p></span></p>
</div>
</div>
</body>
</html>