<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Wang, Quanxian Sent: Wednesday, March 19, 2014 10:03 AM To: 'Jason Ekstrand' Cc: ppaalanen@gmail.com; wayland-devel@lists.freedesktop.org Subject: RE: [PATCH 2/3] weston:Add wl_output name event<o:p></o:p> </div> </div> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Jason Ekstrand [<a href="mailto:jason@jlekstrand.net">mailto:jason@jlekstrand.net</a>] Sent: Wednesday, March 19, 2014 8:55 AM To: Wang, Quanxian Cc: <a href="mailto:ppaalanen@gmail.com">ppaalanen@gmail.com</a>; <a href="mailto:wayland-devel@lists.freedesktop.org"> wayland-devel@lists.freedesktop.org</a> Subject: RE: [PATCH 2/3] weston:Add wl_output name event<o:p></o:p> </div> </div> <o:p> </o:p> On Mar 16, 2014 5:30 AM, "Wang, Quanxian" <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> wrote: > > > > > > From: Jason Ekstrand [mailto:<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>] > Sent: Saturday, March 15, 2014 9:10 PM > > To: Wang, Quanxian > Cc: <a href="mailto:ppaalanen@gmail.com">ppaalanen@gmail.com</a>; <a href="mailto:wayland-devel@lists.freedesktop.org"> wayland-devel@lists.freedesktop.org</a> > Subject: RE: [PATCH 2/3] weston:Add wl_output name event > > > > > On Mar 15, 2014 4:57 AM, "Wang, Quanxian" <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> wrote: > > > > > > > > > > > > From: Jason Ekstrand [mailto:<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>] > > Sent: Saturday, March 15, 2014 3:54 AM > > To: Wang, Quanxian > > Cc: <a href="mailto:ppaalanen@gmail.com">ppaalanen@gmail.com</a>; <a href="mailto:wayland-devel@lists.freedesktop.org"> wayland-devel@lists.freedesktop.org</a> > > > > Subject: Re: [PATCH 2/3] weston:Add wl_output name event > > > > > > > > > > On Mar 13, 2014 9:12 PM, "Quanxian Wang" <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> wrote: > > > > > > Signed-off-by: Quanxian Wang <<a href="mailto:quanxian.wang@intel.com">quanxian.wang@intel.com</a>> > > > --- > > > src/compositor.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/src/compositor.c b/src/compositor.c > > > index 98a4f6f..8e8964b 100644 > > > --- a/src/compositor.c > > > +++ b/src/compositor.c > > > @@ -3045,6 +3045,9 @@ bind_output(struct wl_client *client, > > > } > > > > > > if (version >= 2) > > > + wl_output_send_name(resource, output->name); > > > > As with my comment on the protocol, wl_output_send_name should be version 3, not version 2. That should also clear up Bryce's comment. > > > > [Wang, Quanxian] if it is 2, patch 3/3 is not needed because currently shell only support version 2. Right? > > We should still have patch 3 since weston should always support the latest version of everything. > > [Wang, Quanxian]That is fine according to my testing. If no patch 3/3, desktop-shell will crash. I am not sure if more updates are needed. For example, in our shell code, we use such code min(2, version) for wl_output interface, should we change it to minal(3,version) if merge this patch?<o:p></o:p> Of anything is crashing, chances are that something is wrong. Perhaps this is tied to adding events without bumping the version number?<o:p></o:p> [Wang, Quanxian] maybe, I will have a try and check if it is the bump issue which cause client crash. Thanks for your reminder. If it is, patch 3 is not needed. If we want to support latest version, we should bump wl_output to version 3 and add name listener.<o:p></o:p> [Wang, Quanxian] I have tested it. It works as your said. The crash happens without bumping the version number. I will send the patch series later with updates in shell. Thanks<o:p></o:p> --Jason Ekstrand<o:p></o:p> > > > > > Thanks, > > --Jason Ekstrand > > > > > + > > > + if (version >= 2) > > > wl_output_send_done(resource); > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > _______________________________________________ > > > wayland-devel mailing list > > > <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> > > > <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><o:p></o:p> </div> </div> </div> </body> </html>