<div dir="ltr"><div>Kristian,<br>Other than the "return FALSE" mentioned below, this looks good-to-go.<br></div>--Jason Ekstrand<br><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 2, 2014 at 7:43 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="">On Wed, Apr 2, 2014 at 7:08 PM, Bill Spitzak <span dir="ltr"><<a href="mailto:spitzak@gmail.com" target="_blank">spitzak@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Hardening wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+                       if (!settings->DesktopResize) {<br>
+                               /* peer does not support desktop resize */<br>
+                               weston_log("%s: client doesn't support resizing, closing connection\n", __FUNCTION__);<br>
+                               client->Close(client);<br>
</blockquote>
<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+                       target_mode = ensure_matching_mode(&output-><u></u>base, &new_mode);<div><br>
+                       if (!target_mode) {<br>
+                               weston_log("client mode not found\n");<br>
+                               return FALSE;<br>
+                       }<br>
</div></blockquote>
<br>
One failure mode is fatal, while the other one just returns FALSE? Both just mean that weston's size is different than the RDP window size, so I think the results should be the same.<br></blockquote><div><br></div></div>
<div>
Actually, I *think* what he's doing here is sane.  However, we should probably return FALSE in both cases.<span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888"><div>
--Jason Ekstrand <br></div></font></span></div></div></div>
</blockquote></div><br></div></div></div></div>