<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Tue, May 6, 2014 at 9:46 PM, Boyan Ding <<a href="mailto:stu_dby@126.com" target="_blank">stu_dby@126.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">--- shared/cairo-util.h | 3 +++ shared/frame.c | 24 ++++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/shared/cairo-util.h b/shared/cairo-util.h index 4493b0d..7aebb65 100644 --- a/shared/cairo-util.h +++ b/shared/cairo-util.h @@ -211,6 +211,9 @@ void frame_touch_up(struct frame *frame, void *data, int32_t id); void +frame_touch_motion(struct frame *frame, void *data, int32_t id, int x, int y); + +void frame_repaint(struct frame *frame, cairo_t *cr); #endif diff --git a/shared/frame.c b/shared/frame.c index 35e6b65..df51eca 100644 --- a/shared/frame.c +++ b/shared/frame.c @@ -837,6 +837,30 @@ frame_touch_up(struct frame *frame, void *data, int32_t id) } void +frame_touch_motion(struct frame *frame, void *data, int32_t id, int x, int y) +{ + struct frame_touch *touch = frame_touch_get(frame, data); + struct frame_button *button = frame_find_button(frame, x, y); + + if (id > 0 || !touch) + return; + + touch->x = x; + touch->y = y; + + if (touch->button == button) + return ; + + if (touch->button) + frame_button_release(touch->button); + + touch->button = button; + + if (touch->button) + frame_button_press(touch->button); </blockquote><div> </div><div>Are you sure that these are the semantics we want? Most touch interfaces, don't let you slide onto a button. For instance, given the way this is written, if you put your finger down, slide onto the close button and then slide off without picking up your finger, the close button will see a press and a release and the window will close. I think what we want to do here is to mirror what is done for a mouse pointer. Only press the button on finger down and then, on finger up either release or cancel the button depending on whether the finger is still on the button or not. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+} + +void frame_repaint(struct frame *frame, cairo_t *cr) { struct frame_button *button; -- 1.9.2 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div></div>