<div dir="ltr">Hm, it seems to me that hiding a layer should cause all the regions it occupied to be marked as needing repaint. Fixing the scene graph is better than a one-off at the end of an animation.<br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira <span dir="ltr"><<a href="mailto:conselvan2@gmail.com" target="_blank">conselvan2@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Ander Conselvan de Oliveira <<a href="mailto:ander.conselvan.de.oliveira@intel.com">ander.conselvan.de.oliveira@intel.com</a>><br>
<br>
Views that extend past the bottom of the output are still visible after<br>
the workspace animation ends but before its layer is hidden. When the<br>
layer was hidden, nothing would cause those regions to be repainted,<br>
leading to artifacts.<br>
<br>
<a href="https://bugs.freedesktop.org/show_bug.cgi?id=78363" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=78363</a><br>
---<br>
desktop-shell/shell.c | 9 +++++++++<br>
1 file changed, 9 insertions(+)<br>
<br>
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c<br>
index a631c62..fac3120 100644<br>
--- a/desktop-shell/shell.c<br>
+++ b/desktop-shell/shell.c<br>
@@ -1027,8 +1027,17 @@ finish_workspace_change_animation(struct desktop_shell *shell,<br>
struct workspace *from,<br>
struct workspace *to)<br>
{<br>
+ struct weston_view *view;<br>
+<br>
weston_compositor_schedule_repaint(shell->compositor);<br>
<br>
+ /* Views that extend past the bottom of the output are still<br>
+ * visible after the workspace animation ends but before its layer<br>
+ * is hidden. In that case, we need to damage below those views so<br>
+ * that the screen is properly repainted. */<br>
+ wl_list_for_each(view, &from->layer.view_list, layer_link)<br>
+ weston_view_damage_below(view);<br>
+<br>
wl_list_remove(&shell->workspaces.animation.link);<br>
workspace_deactivate_transforms(from);<br>
workspace_deactivate_transforms(to);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.2<br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br> Jasper<br>
</div>