<div dir="ltr">Yes we should fix this.  I have one question below.<br><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding <span dir="ltr"><<a href="mailto:stu_dby@126.com" target="_blank">stu_dby@126.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell<br>
implementations' forgot to set shsurf->fullscreen_optput in<br>
fullscreen_binding(), causing weston to segfault when fullscreen<br>
with the mod + shift + f binding. This patch fixed that issue.<br>
---<br>
 desktop-shell/shell.c | 6 ++++++<br>
 1 file changed, 6 insertions(+)<br>
<br>
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c<br>
index dd0b2f9..56ffebf 100644<br>
--- a/desktop-shell/shell.c<br>
+++ b/desktop-shell/shell.c<br>
@@ -4180,6 +4180,12 @@ fullscreen_binding(struct weston_seat *seat, uint32_t time, uint32_t button, voi<br>
<br>
        shsurf->state_requested = true;<br>
        shsurf->requested_state.fullscreen = !shsurf->state.fullscreen;<br>
+<br>
+       if (shsurf->requested_state.fullscreen) {<br>
+               shell_surface_set_output(shsurf, NULL);<br></blockquote><div><br></div><div>Why are we setting the output to null?  Prior to 9aa8ce69, it was getting set to shsurf->recommended_output.  Was there a reason for the change to null?  Does it not matter?<br>
<br>Thanks,<br></div><div>--Jason Ekstrand<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+               shsurf->fullscreen_output = shsurf->output;<br>
+       }<br>
+<br>
        send_configure_for_surface(shsurf);<br>
 }<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.9.3<br>
<br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</font></span></blockquote></div><br></div></div></div></div>