<div dir="ltr"><div><div><div><div><div>Well, I removed recommended_output in that patch, because it became unnecessary. The set to NULL makes no sense to me either.<br><br></div><div>You should just be able to do a one-line patch:<br>
<br></div>+    shsurf->fullscreen_output = shsurf->output;<br><br></div>I don't see any need for anything more fancy. I'd also add a comment along those lines:<br><br></div>+    /* When the user presses the fullscreen binding they probably<br>
</div>+     * want this window fullscreen on the current monitor. */<br></div>+    shsurf->fullscreen_output = shsurf->output;<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 25, 2014 at 2:00 AM, Boyan Ding <span dir="ltr"><<a href="mailto:stu_dby@126.com" target="_blank">stu_dby@126.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Tue, 2014-06-24 at 21:40 -0700, Jason Ekstrand wrote:<br>
> Yes we should fix this.  I have one question below.<br>
</div>Actually I'm not very sure about that either, maybe we should ask<br>
@Jasper for suggestion.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding <<a href="mailto:stu_dby@126.com">stu_dby@126.com</a>> wrote:<br>
>         Commit 9aa8ce69 'shell: Don't use the helper methods in<br>
>         xdg_shell<br>
>         implementations' forgot to set shsurf->fullscreen_optput in<br>
>         fullscreen_binding(), causing weston to segfault when<br>
>         fullscreen<br>
>         with the mod + shift + f binding. This patch fixed that issue.<br>
>         ---<br>
>          desktop-shell/shell.c | 6 ++++++<br>
>          1 file changed, 6 insertions(+)<br>
><br>
>         diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c<br>
>         index dd0b2f9..56ffebf 100644<br>
>         --- a/desktop-shell/shell.c<br>
>         +++ b/desktop-shell/shell.c<br>
>         @@ -4180,6 +4180,12 @@ fullscreen_binding(struct weston_seat<br>
>         *seat, uint32_t time, uint32_t button, voi<br>
><br>
>                 shsurf->state_requested = true;<br>
>                 shsurf->requested_state.fullscreen = !<br>
>         shsurf->state.fullscreen;<br>
>         +<br>
>         +       if (shsurf->requested_state.fullscreen) {<br>
>         +               shell_surface_set_output(shsurf, NULL);<br>
><br>
><br>
> Why are we setting the output to null?  Prior to 9aa8ce69, it was<br>
> getting set to shsurf->recommended_output.  Was there a reason for the<br>
> change to null?  Does it not matter?<br>
><br>
> Thanks,<br>
><br>
> --Jason Ekstrand<br>
><br>
><br>
>         +               shsurf->fullscreen_output = shsurf->output;<br>
>         +       }<br>
>         +<br>
>                 send_configure_for_surface(shsurf);<br>
>          }<br>
><br>
>         --<br>
>         1.9.3<br>
><br>
><br>
>         _______________________________________________<br>
>         wayland-devel mailing list<br>
>         <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
>         <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
><br>
><br>
<br>
<br>
<br>
_______________________________________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>  Jasper<br>
</div>