<div dir="ltr"><div>I just pushed this because it fixes a bug. I really don't like the fact that we have to track this separately from spring.target. We should probably fix the animation code so we don't. </div> --Jason Ekstrand </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Jul 29, 2014 at 4:56 PM, Jonny Lamb <<a href="mailto:jonny.lamb@collabora.co.uk" target="_blank">jonny.lamb@collabora.co.uk</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If we're fading a view with weston_fade_run() and half way through we want to unfade it we can use weston_fade_update() to set a new alpha target. When the animation finishes, reset_alpha() is called which ensures the alpha value of the view is exactly as requested. Although weston_fade_update() was updating the spring target so the animation would look fine, it would then reset to the alpha target given in the first call to weston_fade_run(). --- src/animation.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/animation.c b/src/animation.c index 5ded3ad..0febe41 100644 --- a/src/animation.c +++ b/src/animation.c @@ -330,6 +330,7 @@ WL_EXPORT void weston_fade_update(struct weston_view_animation *fade, float target) { fade->spring.target = target; + fade->stop = target; } static void -- 2.0.1 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div>