<div dir="ltr"><div>Thanks for taking this on. I'm disappointed about the duplication, but if somebody else does the work, I can't really complain. The whole series is: </div> Reviewed-by: Jasper St. Pierre <<a href="mailto:jstpierre@mecheye.net">jstpierre@mecheye.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Oct 1, 2014 at 7:50 AM, Pekka Paalanen <<a href="mailto:ppaalanen@gmail.com" target="_blank">ppaalanen@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Pekka Paalanen <<a href="mailto:pekka.paalanen@collabora.co.uk">pekka.paalanen@collabora.co.uk</a>> Hi, this is my attempt on the wl_surface role conflict (trying to change a surface role) error patches. Jasper's original version is here: <a href="http://lists.freedesktop.org/archives/wayland-devel/2014-August/016810.html" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2014-August/016810.html</a> <a href="http://lists.freedesktop.org/archives/wayland-devel/2014-August/016811.html" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2014-August/016811.html</a> The main differences are noted in the "compositor:" patch. Thanks, pq Pekka Paalanen (1): protocol: define error codes for role reassignment protocol/wayland.xml | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) Pekka Paalanen (3): protocol: add role error code to xdg_shell compositor: send error for surface role resets tests: add role conflict sub-surface vs. wl_shell_surface Makefile.am | 5 ++ desktop-shell/shell.c | 38 ++++--------- protocol/xdg-shell.xml | 9 +++ src/compositor.c | 33 +++++++++-- src/compositor.h | 15 +++++ src/data-device.c | 11 ++-- src/input.c | 11 ++-- tests/roles-test.c | 139 ++++++++++++++++++++++++++++++++++++++++++++++ xwayland/window-manager.c | 7 +++ 9 files changed, 222 insertions(+), 46 deletions(-) create mode 100644 tests/roles-test.c -- 1.8.5.5 </blockquote></div> -- Jasper </div>