<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 9 December 2014 at 21:39, Derek Foreman <span dir="ltr"><<a href="mailto:derekf@osg.samsung.com" target="_blank">derekf@osg.samsung.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On 05/12/14 07:36 AM, Marek Chalupa wrote:<br>
> ---<br>
>  protocol/wayland-test.xml         | 11 +++++++++++<br>
>  tests/weston-test-client-helper.c | 18 ++++++++++++++++++<br>
>  tests/weston-test-client-helper.h |  6 ++++++<br>
>  tests/weston-test.c               | 23 +++++++++++++++++++++++<br>
>  4 files changed, 58 insertions(+)<br>
><br>
> diff --git a/protocol/wayland-test.xml b/protocol/wayland-test.xml<br>
> index 18b6625..b4a6bc7 100644<br>
> --- a/protocol/wayland-test.xml<br>
> +++ b/protocol/wayland-test.xml<br>
> @@ -3,6 +3,7 @@<br>
<br>
</span>I think we need to bump the interface version number when adding new stuff?<br>
<span class=""><br></span></blockquote><div><br></div><div>In previous commits to this protocol this was not true (e. g. 40c0c3f91eeb747b86df) - probably because nobody cares about it since its testing..<br></div><div>Anyway, strictly speaking, yes, we should.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
> +static void<br>
> +get_geometry(struct wl_client *client, struct wl_resource *resource,<br>
> +          struct wl_resource *surface_resource)<br>
> +{<br>
> +     struct weston_view *view;<br>
> +     struct weston_surface *surface =<br>
> +             wl_resource_get_user_data (surface_resource);<br>
<br>
</span>I don't think we put a space there...<br></blockquote><div><br></div><div>Ooops.<br><br><br>Thanks,<br>Marek <br></div></div><br></div></div>