<div dir="ltr"><div>Checking for negative return value of snprintf is wrong, but snprintf can actually "fail". It can truncate the output. However, since sizeof name is 256 and the length of "XWAYLAND%d" is always shorter that this, it is safe here. </div>Reviewed-by: Marek Chalupa <<a href="mailto:mchqwerty@gmail.com">mchqwerty@gmail.com</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, May 12, 2015 at 7:21 PM, Dima Ryazanov <<a href="mailto:dima@gmail.com" target="_blank">dima@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">snprintf does not allocate memory, so we can never get an out-of-memory error. (Also, the error handler would free xwl_output after it was already registered as an event listener.) Signed-off-by: Dima Ryazanov <<a href="mailto:dima@gmail.com">dima@gmail.com</a>> --- hw/xwayland/xwayland-output.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c index 1d75d0b..4949363 100644 --- a/hw/xwayland/xwayland-output.c +++ b/hw/xwayland/xwayland-output.c @@ -167,11 +167,7 @@ xwl_output_create(struct xwl_screen *xwl_screen, uint32_t id) &wl_output_interface, 2); wl_output_add_listener(xwl_output->output, &output_listener, xwl_output); - if (snprintf(name, sizeof name, "XWAYLAND%d", serial++) < 0) { - ErrorF("create_output ENOMEM\n"); - free(xwl_output); - return NULL; - } + snprintf(name, sizeof name, "XWAYLAND%d", serial++); xwl_output->xwl_screen = xwl_screen; xwl_output->randr_crtc = RRCrtcCreate(xwl_screen->screen, xwl_output); -- 2.4.0 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div>