<div dir="ltr">Hi, <br><br><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 22, 2015 at 3:37 AM, Peter Hutterer <span dir="ltr"><<a href="mailto:peter.hutterer@who-t.net" target="_blank">peter.hutterer@who-t.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Fri, Jun 19, 2015 at 03:24:38PM +0200, Andreas Pokorny wrote:<br>
> +      * */<br>
> +     if (orientation_info) {<br>
> +             if (orientation_info->maximum == 1 &&<br>
> +                 orientation_info->maximum == 0)<br>
> +                     return orientation == 0?90.0:0.0;<br>
<br>
</div></div>spaces around ? and :<br>
<span><br>
> +     }<br>
> +     else<br>
> +             return DEFAULT_TOUCH_ORIENTATION;<br>
<br>
</span>{ } for if + else when either of them requires it, please check the<br>
CODING_STYLE document.<br></blockquote><div><br></div><div>That info is not yet in the CODING_STYLE. <br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
> +}<br>
> +<br>
> +double<br>
> +evdev_device_transform_pressure(struct evdev_device *device,<br>
> +                             int32_t pressure)<br>
> +{<br>
> +     const struct input_absinfo *pressure_info = device->abs.absinfo_pressure;<br>
> +<br>
> +     if (pressure_info)<br>
> +             return (double)(pressure - pressure_info->minimum) /<br>
> +                     (pressure_info->maximum - pressure_info->minimum);<br>
<br>
</span>tmp variable for min/max here too please<br>
<span><br>
> +                                       slot_data->pressure);<br>
>               break;<br>
>       case EVDEV_ABSOLUTE_MT_UP:<br>
>               if (!(device->seat_caps & EVDEV_DEVICE_TOUCH))<br>
> @@ -371,7 +447,9 @@ evdev_flush_pending_event(struct evdev_device *device, uint64_t time)<br>
>               point = device->abs.point;<br>
>               transform_absolute(device, &point);<br>
><br>
> -             touch_notify_touch_down(base, time, -1, seat_slot, &point);<br>
> +             touch_notify_touch_down(base, time, -1, seat_slot, &point,<br>
> +                                     DEFAULT_TOUCH_MAJOR,l DEFAULT_TOUCH_MINOR,<br>
<br>
</span>does this even compile?<br></blockquote><div><br></div><div>ouch how embarrassing. I added that error while reiterating and cleaning out (most) expanded tabs.. <br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
> +                                     DEFAULT_TOUCH_ORIENTATION, DEFAULT_TOUCH_PRESSURE);<br>
<br>
one arg per line.<br></blockquote><div><br></div><div>Ok - on that one I was about to do it, but hesitated as the existing code wrapped in the middle of the parameter set. <br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><br>
[...]<br></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
ok, I'm going to skip the rest. Please go through this patchset again and<br>
make sure you adhere to the coding style before resubmitting. The odd issue<br>
here and there is one thing, but having that many, including a compilation<br>
errors should not happen.<br></blockquote></div><br></div><div class="gmail_extra">Fine, found some further violations - resending another version now. Thanks for the review. <br><br></div><div class="gmail_extra">regards<br></div><div class="gmail_extra">Andreas Pokorny<br></div><div class="gmail_extra"><br></div></div></div>