<div dir="ltr"><div><div><div><div><div>Hello dear community,<br><br></div>in our current project we are trying to follow the weston master branch as much as possible,<br></div>recently introduced dependency to libdrm 2.4.59 will prevent us to use weston 1.9,<br></div>The patches for naming correction are good and important.<br></div>so we would love to see a missing defines in the corresponding #ifdef statement.<br><br></div><div>Are display name defines the only reason to add a dependency to 2.4.59?<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-08-24 10:52 GMT+02:00 Pekka Paalanen <span dir="ltr"><<a href="mailto:ppaalanen@gmail.com" target="_blank">ppaalanen@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, 21 Aug 2015 23:24:54 -0700<br> Bryce Harrington <<a href="mailto:bryce@osg.samsung.com">bryce@osg.samsung.com</a>> wrote:<br> <br> > On Fri, Aug 21, 2015 at 11:06:02PM -0500, Derek Foreman wrote:<br> > > commit 89c49b3060a115e846ba1e7fbef94d14894244f2 changed the way we name<br> > > outputs, but it also added the new output names VIRTUAL and DSI.<br> > ><br> > > These aren't available until libdrm 2.4.59<br> <br> </span>Hi,<br> <br> sorry I forgot to check when those appeared.<br> <span class=""><br> > Ubuntu 14.04 appears to have 2.4.60. Presumably other distros of that<br> > vintige will have similar. So this looks like a reasonable dependency<br> > bump to me.<br> ><br> > > Signed-off-by: Derek Foreman <<a href="mailto:derekf@osg.samsung.com">derekf@osg.samsung.com</a>><br> ><br> > Reviewed-by: Bryce Harrington <<a href="mailto:bryce@osg.samsung.com">bryce@osg.samsung.com</a>><br> <br> </span>Alright. It would be very easy to just #ifdef these in case we wanted<br> to keep the libdrm requirement the same. I pushed your patch, and we<br> can fix it the other way if someone complains. (It's a 3 year bump, so<br> I'm not surprised if I need to fix it the other way.)<br> decc965..faee330 master -> master<br> <br> <br> Thanks,<br> pq<br> <div class="HOEnZb"><div class="h5"><br> > > ---<br> > > <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 +-<br> > > 1 file changed, 1 insertion(+), 1 deletion(-)<br> > ><br> > > diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > > index 425f071..d70777d 100644<br> > > --- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > > +++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > > @@ -171,7 +171,7 @@ AC_ARG_ENABLE(drm-compositor, [ --enable-drm-compositor],,<br> > > AM_CONDITIONAL(ENABLE_DRM_COMPOSITOR, test x$enable_drm_compositor = xyes)<br> > > if test x$enable_drm_compositor = xyes; then<br> > > AC_DEFINE([BUILD_DRM_COMPOSITOR], [1], [Build the DRM compositor])<br> > > - PKG_CHECK_MODULES(DRM_COMPOSITOR, [libudev >= 136 libdrm >= 2.4.30 gbm mtdev >= 1.1.0])<br> > > + PKG_CHECK_MODULES(DRM_COMPOSITOR, [libudev >= 136 libdrm >= 2.4.59 gbm mtdev >= 1.1.0])<br> > > PKG_CHECK_MODULES(DRM_COMPOSITOR_GBM, [gbm >= 10.2],<br> > > [AC_DEFINE([HAVE_GBM_FD_IMPORT], 1, [gbm supports dmabuf import])],<br> > > [AC_MSG_WARN([gbm does not support dmabuf import, will omit that capability])])<br> > > --<br> > > 2.4.6<br> </div></div><br>_______________________________________________<br> wayland-devel mailing list<br> <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br> <br></blockquote></div><br></div>