<div dir="ltr"><div class="gmail_extra"><div><div class="gmail_signature"><div dir="ltr">On Tue, Sep 22, 2015 at 6:38 PM, Bryce Harrington <span dir="ltr"><<a href="mailto:bryce@osg.samsung.com" target="_blank">bryce@osg.samsung.com</a>></span> wrote:<br></div></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tue, Sep 22, 2015 at 02:36:44PM -0700, Bryce Harrington wrote:<br>
> On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote:<br>
> > layout_transition_register could not work and we need to free trans in<br>
> > the calling function.<br>
> ><br>
> > Signed-off-by: Lucas Tanure <<a href="mailto:tanure@linux.com">tanure@linux.com</a>><br>
><br>
> LGTM,<br>
><br>
> Reviewed-by: Bryce Harrington <<a href="mailto:bryce@osg.samsung.com">bryce@osg.samsung.com</a>><br>
<br>
</span>Both patches landed, along with the other ivi-layout-transition patch.<br>
<br>
remote: I: patch #60019 updated using rev 9af00170771fe010df1bab2501fcbfb98ebfc5e0<br>
remote: I: patch #60031 updated using rev 9b5fe423bf7f4f23872a6d678d261b7f995fbd52<br>
remote: I: patch #60032 updated using rev 96db07741f375e28442cbcd3a6471f370da055de<br>
remote: I: 3 patch(es) updated to state Accepted.<br>
To ssh://<a href="http://git.freedesktop.org/git/wayland/weston" rel="noreferrer" target="_blank">git.freedesktop.org/git/wayland/weston</a><br>
8c15360..96db077 master -> master<br>
<div class=""><div class="h5"><br>
<br>
> > ---<br>
> > ivi-shell/ivi-layout-transition.c | 6 ++++--<br>
> > 1 file changed, 4 insertions(+), 2 deletions(-)<br>
> ><br>
> > diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c<br>
> > index 6370e8f..8d477b4 100644<br>
> > --- a/ivi-shell/ivi-layout-transition.c<br>
> > +++ b/ivi-shell/ivi-layout-transition.c<br>
> > @@ -27,6 +27,7 @@<br>
> > #include <assert.h><br>
> > #include <stdlib.h><br>
> > #include <stdio.h><br>
> > +#include <stdbool.h><br>
> ><br>
> > #include "ivi-layout-export.h"<br>
> > #include "ivi-layout-private.h"<br>
> > @@ -181,7 +182,7 @@ ivi_layout_transition_set_create(struct weston_compositor *ec)<br>
> > return transitions;<br>
> > }<br>
> ><br>
> > -static void<br>
> > +static bool<br>
> > layout_transition_register(struct ivi_layout_transition *trans)<br>
> > {<br>
> > struct ivi_layout *layout = get_instance();<br>
> > @@ -190,11 +191,12 @@ layout_transition_register(struct ivi_layout_transition *trans)<br>
> > node = malloc(sizeof(*node));<br>
> > if (node == NULL) {<br>
> > weston_log("%s: memory allocation fails\n", __func__);<br>
> > - return;<br>
> > + return false;<br>
> > }<br>
> ><br>
> > node->transition = trans;<br>
> > wl_list_insert(&layout->pending_transition_list, &node->link);<br>
> > + return true;<br>
> > }<br>
> ><br>
> > static void<br>
> > --<br>
> > 2.5.3<br>
> ><br>
> > _______________________________________________<br>
> > wayland-devel mailing list<br>
> > <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
> > <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
> _______________________________________________<br>
> wayland-devel mailing list<br>
> <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra">Thanks!<br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div>--</div>Lucas Tanure <br>+55 (19) 988176559</div></div></div></div></div>