<div dir="ltr"><div><div><div>I'm not sure why one of the large patches seems to be attributed to me, it is actually Auke's.<br><br></div>My only contribution was a small patch (number 4) to use the enum/bitfield information in the generated docs. My patch is slightly different that Auke's proposal and he liked it better, I was just holding on to it until the enum patches were applied.<br><br></div>I think the necessary enums were added to the xdg_shell and some other protocol files but I don't see those patches listed.<br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 1, 2015 at 10:59 AM, Jasper St. Pierre <span dir="ltr"><<a href="mailto:jstpierre@mecheye.net" target="_blank">jstpierre@mecheye.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We have a few constraints. First off, not all enums are closed. Some<br> are intentionally open, like xdg_shell.state. So we definitely need a<br> distinction between a closed enum and an open enum. I'm not familiar<br> enough with Rust to be able to apply something to that.<br> <br> Second, I think we need to make a big effort to map out how the XML<br> converts to a wire format. For the most part, it's obvious, except for<br> the n -> sun hack we apply when we don't have an interface name. We<br> should probably specify that somewhere.<br> <br> There's also a compatibility issue that has been brought up, but I<br> never understood that one. Somebody else would be able to talk about<br> that better.<br> <div><div class="h5"><br> On Thu, Oct 1, 2015 at 10:49 AM, Bryce Harrington <<a href="mailto:bryce@osg.samsung.com">bryce@osg.samsung.com</a>> wrote:<br> > The topic of adding better enum/bitfield support to the protocol has<br> > come up a few[0] times[1] in the past, and again more recently[2]. We<br> > also have several proposed patches in patchwork, but I'm not sure they<br> > reflect consensus and none have Reviewed-by's on them yet [3,4,5,6,7].<br> ><br> > From what I gather of the discussions, no one is really against this<br> > feature conceptually, and impementationally the discussions appear to<br> > have moved further afield. It feels like we're real close to having<br> > something that could be landed, but it's not 100% clear to me what<br> > exactly to land. Since it's a protocol types change I would prefer to<br> > make sure it has a strong consensus before landing it.<br> ><br> > I know that several people have proposed patches on this - Bill, Nils<br> > and Auke at least. Since there's a definite need for this, and since<br> > agreement appears to be not far off, I would like to get this landed<br> > this release. And ideally I'd like to get this landed early in the<br> > release so we give plenty of time for testing.<br> ><br> > Since Auke's patchset proposalis the most recent, let's take that one as<br> > the candidate for landing. Gentlemen, I'd like to ask you to review<br> > these three patches [5,6,7] and either give your Reviewed-by's or flag<br> > specific improvements needed. If you have a more conceptual<br> > disagreement, and don't think the patchset is landable as implemented,<br> > please raise that issue asap too.<br> ><br> > Bryce<br> ><br> > 0: <a href="http://lists.freedesktop.org/archives/wayland-devel/2015-April/021438.html" rel="noreferrer" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2015-April/021438.html</a><br> > 1: <a href="http://lists.freedesktop.org/archives/wayland-devel/2015-June/023008.html" rel="noreferrer" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2015-June/023008.html</a><br> > 2: <a href="http://lists.freedesktop.org/archives/wayland-devel/2015-September/024249.html" rel="noreferrer" target="_blank">http://lists.freedesktop.org/archives/wayland-devel/2015-September/024249.html</a><br> ><br> > 3: <a href="http://patchwork.freedesktop.org/patch/47726/" rel="noreferrer" target="_blank">http://patchwork.freedesktop.org/patch/47726/</a><br> > 4: <a href="http://patchwork.freedesktop.org/patch/47727/" rel="noreferrer" target="_blank">http://patchwork.freedesktop.org/patch/47727/</a><br> > 5: <a href="http://patchwork.freedesktop.org/patch/53018/" rel="noreferrer" target="_blank">http://patchwork.freedesktop.org/patch/53018/</a><br> > 6: <a href="http://patchwork.freedesktop.org/patch/53019/" rel="noreferrer" target="_blank">http://patchwork.freedesktop.org/patch/53019/</a><br> > 7: <a href="http://patchwork.freedesktop.org/patch/53020/" rel="noreferrer" target="_blank">http://patchwork.freedesktop.org/patch/53020/</a><br> </div></div>> _______________________________________________<br> > wayland-devel mailing list<br> > <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a><br> <span class="HOEnZb"><font color="#888888"><br> <br> <br> --<br> Jasper<br> </font></span></blockquote></div><br></div>