<div dir="ltr">Hi,<div>Â Â It's missing README, but otherwise it looks good to me:</div><div> </div><div>Reviewed-by: Mariusz Ceier <<a href="mailto:mceier%2Bwayland@gmail.com">mceier+wayland@gmail.com</a>></div><div> </div><div>Mariusz Ceier </div></div><div class="gmail_extra"> <div class="gmail_quote">On 25 November 2015 at 15:10, Giulio Camuffo <<a href="mailto:giuliocamuffo@gmail.com" target="_blank">giuliocamuffo@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This new extension is used by clients wanting to execute priviledged actions such as taking a screenshot. The usual way of granting special priviledged to apps is to fork and exec them in the compositor, and then checking if the client is the known one when it binds the restricted global interface. This works but is quite limited, as it doesn't allow the compositor to ask the user if the app is trusted, because it can't wait for the answer in the bind function as that would block the compositor. This new protocol instead allows the answer to come after some time without blocking the compositor or the client. --- v2: renamed to restricted_registry. Â Â It now replaces wl_registry entirely for the restricted interfaces Â Â and hence it makes it lets clients know for sure that the globals Â Â in wl_registry are not restricted, and which are the restricted Â Â ones. Â Makefile.amÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 1 + Â .../restricted-registry/restricted-registry-v1.xml | 148 +++++++++++++++++++++ Â 2 files changed, 149 insertions(+) Â create mode 100644 unstable/restricted-registry/restricted-registry-v1.xml diff --git a/Makefile.am b/Makefile.am index a32e977..bfe9a6a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,6 +5,7 @@ unstable_protocols =Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \ Â Â Â Â unstable/text-input/text-input-unstable-v1.xmlÂ Â Â Â Â Â Â Â Â Â Â Â Â \ Â Â Â Â unstable/input-method/input-method-unstable-v1.xmlÂ Â Â Â Â Â Â Â Â Â Â \ Â Â Â Â unstable/xdg-shell/xdg-shell-unstable-v5.xmlÂ Â Â Â Â Â Â Â Â Â Â Â Â Â \ +Â Â Â Â unstable/authorizer/authorizer-unstable-v1.xml Â Â Â Â $(NULL) Â nobase_dist_pkgdata_DATA =Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \ diff --git a/unstable/restricted-registry/restricted-registry-v1.xml b/unstable/restricted-registry/restricted-registry-v1.xml new file mode 100644 index 0000000..8c9224f --- /dev/null +++ b/unstable/restricted-registry/restricted-registry-v1.xml @@ -0,0 +1,148 @@ +<?xml version="1.0" encoding="UTF-8"?> +<protocol name="restricted_registry_v1"> + +Â <copyright> +Â Â Copyright Â© 2015 Giulio Camuffo. + +Â Â Permission to use, copy, modify, distribute, and sell this +Â Â software and its documentation for any purpose is hereby granted +Â Â without fee, provided that the above copyright notice appear in +Â Â all copies and that both that copyright notice and this permission +Â Â notice appear in supporting documentation, and that the name of +Â Â the copyright holders not be used in advertising or publicity +Â Â pertaining to distribution of the software without specific, +Â Â written prior permission.Â The copyright holders make no +Â Â representations about the suitability of this software for any +Â Â purpose.Â It is provided "as is" without express or implied +Â Â warranty. + +Â Â THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS +Â Â SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND +Â Â FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY +Â Â SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +Â Â WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN +Â Â AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, +Â Â ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF +Â Â THIS SOFTWARE. +Â </copyright> + +Â <interface name="zwp_restricted_registry_v1" version="1"> +Â Â <description summary="authorize clients to use certain interfaces"> +Â Â Â This global interface acts as a wl_registry for restricted interfaces. + +Â Â Â The globals advertized through this extension are not available +Â Â Â through the normal wl_registry, and are not bindable by all the +Â Â Â clients. +Â Â Â When the clients creates a new zwp_restricted_registry_v1 object, +Â Â Â it will advertize the existing restricted globals through the global +Â Â Â event. These globals are not immediately bindable, but the client +Â Â Â needs to be authorized first. To do so, the clients should send +Â Â Â the authorize request for each global it whishes to bind, and then +Â Â Â notify the compositor it whishes to be authorized by using the +Â Â Â commit_authorization request. The compositor will then process the +Â Â Â request and then send the list of authorized globals with the +Â Â Â global_authorized event, followed by the authorization_done event. +Â Â Â The client can bind the authorized globals when they are advertized +Â Â Â but trying to bind any other will trigger a protocol error killing +Â Â Â the client. + +Â Â Â The list of restricted interfaces is compositor dependant, but must +Â Â Â not include the core interfaces defined in wayland.xml. +Â Â </description> + +Â Â <enum name="error"> +Â Â Â <description summary="zwp_restricted_registry_v1 error codes"> +Â Â Â Â These errors can be emitted in response of zwp_restricted_registry_v1 +Â Â Â Â requests. +Â Â Â </description> +Â Â Â <entry name="unauthorized" value="0" +Â Â Â Â Â Â Â summary="the client is not authorized to bind the specified global"/> +Â Â </enum> + +Â Â <request name="destroy" type="destructor"> +Â Â Â <description summary="destroy this zwp_restricted_registry_v1 object"> +Â Â Â Â Destroy this object. Any bound object will continue to live. +Â Â Â </description> +Â Â </request> + +Â Â <request name="bind"> +Â Â Â <description summary="bind an object to the display"> +Â Â Â Â Binds a new, client-created object to the server using the +Â Â Â Â specified name as the identifier. +Â Â Â Â The global must have been authorized prior to binding it +Â Â Â Â by using the authorize request, otherwise the server will +Â Â Â Â send a protocol error. +Â Â Â </description> +Â Â Â <arg name="name" type="uint" summary="unique name for the object"/> +Â Â Â <arg name="id" type="new_id"/> +Â Â </request> + +Â Â <request name="authorize"> +Â Â Â <description summary="authorize a global interface"> +Â Â Â Â The authorize request allows the client to ask the compositor for +Â Â Â Â authorization to bind a restricted global interface. +Â Â Â </description> +Â Â Â <arg name="name" type="uint"/> +Â Â </request> + +Â Â <request name="commit_authorization"> +Â Â Â <description summary="issue the authorization requests"> +Â Â Â Â This request notifies the compositor that the client has requested +Â Â Â Â all the authorizations for the globals it wants to bind. No other +Â Â Â Â authorize request can be sent after this. +Â Â Â Â The compositor will decide which globals the client is authorized +Â Â Â Â to bind and send them out using the global_authorized event, followed +Â Â Â Â by the authorization_done event. +Â Â Â </description> +Â Â </request> + +Â Â <event name="global"> +Â Â Â <description summary="announce global object"> +Â Â Â Â Notify the client of global objects. + +Â Â Â Â The event notifies the client that a global object with +Â Â Â Â the given name is now available, and it implements the +Â Â Â Â given version of the given interface. +Â Â Â </description> +Â Â Â <arg name="name" type="uint"/> +Â Â Â <arg name="interface" type="string"/> +Â Â Â <arg name="version" type="uint"/> +Â Â </event> + +Â Â <event name="global_remove"> +Â Â Â <description summary="announce removal of global object"> +Â Â Â Â Notify the client of removed global objects. + +Â Â Â Â This event notifies the client that the global identified +Â Â Â Â by name is no longer available.Â If the client bound to +Â Â Â Â the global using the bind request, the client should now +Â Â Â Â destroy that object. + +Â Â Â Â The object remains valid and requests to the object will be +Â Â Â Â ignored until the client destroys it, to avoid races between +Â Â Â Â the global going away and a client sending a request to it. +Â Â Â </description> +Â Â Â <arg name="name" type="uint"/> +Â Â </event> + +Â Â <event name="global_authorized"> +Â Â Â <description summary="the client can bind this global object"> +Â Â Â Â Notify the client that it was authorized to bind this global. +Â Â Â Â Only now can the client bind it succesfully. +Â Â Â </description> +Â Â Â <arg name="name" type="uint"/> +Â Â Â <arg name="interface" type="string"/> +Â Â Â <arg name="version" type="uint"/> +Â Â </event> + +Â Â <event name="authorization_done"> +Â Â Â <description summary="the authorization process is completed"> +Â Â Â Â This event notifies the client that the authorization process +Â Â Â Â is done. Any authorized global was advertized through the +Â Â Â Â global_authorized event, and any other global the client binds +Â Â Â Â will trigger a protocol error. +Â Â Â </description> +Â Â </event> + +Â </interface> +</protocol> -- 2.6.2 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div>