[Xcb-commit] src

Eamon Walsh ewalsh at kemper.freedesktop.org
Tue Apr 7 21:05:21 PDT 2009


 src/xproto.xml |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit fe7b12db4fc0e95f3eef038581bf2154e1727c7a
Author: Eamon Walsh <ewalsh at tycho.nsa.gov>
Date:   Tue Apr 7 23:56:33 2009 -0400

    Correct the length calculation for the value field of GetPropertyReply.
    
    value_len only contains the number of data units, which are 1, 2, or 4
    bytes depending on the value of the format field.  The length of the
    value field is thus value_len multiplied by the bytes per unit,
    which is format / 8.
    
    Signed-off-by: Eamon Walsh <ewalsh at tycho.nsa.gov>

diff --git a/src/xproto.xml b/src/xproto.xml
index 6313da6..920285a 100644
--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -987,7 +987,13 @@ authorization from the authors.
       <field type="CARD32" name="value_len" />
       <pad bytes="12" />
       <list type="void" name="value">
-        <fieldref>value_len</fieldref>
+	<op op="*">
+	  <fieldref>value_len</fieldref>
+	  <op op="/">
+	    <fieldref>format</fieldref>
+	    <value>8</value>
+	  </op>
+	</op>
       </list>
     </reply>
   </request>


More information about the xcb-commit mailing list