[Xcb] [PATCH] Define pthread stub functions when needed

[Jamey Sharp]

On Tue, Nov 21, 2006 at 06:01:07PM +0100, Diego 'Flameeyes' Pettenò wrote:
> Can someone take a look to commit this then, or are there problems still?

I went to commit it a few days ago, but got confused and then distracted
without sending mail. I'm sorry.

On systems that don't need one or both of the new stubs -- by the
numbers, most systems :-) -- the compiler will warn that there are
unused static functions in the new source file. I'd like that fixed. I
spent a while trying to decide how to fix it myself, and that was were I
got confused.

I think it should work to define NEED_ZERO_STUB and NEED_EQUAL_STUB when
appropriate, then conditionally compile __pthread_zero_stub and
__pthread_equal_stub based on the respective macros.

#ifndef HAVE_PTHREAD_SELF
#define NEED_ZERO_STUB
...
#ifdef NEED_ZERO_STUB
static int __pthread_zero_stub()

But please check that this approach works for you.

Also, the patch still wasn't something I could easily apply with git-am.
The mail headers that git-format-patch generates need to be "near" the
body it generates. Intervening MIME containers like GPG-signed parts
break it. Since I like GPG-signed mail, feel free to provide the entire
output of git-format-patch as an attachment.

I've added bug #9112 and set it to block the 1.0 release so we don't
forget about this patch.

--Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20061121/e65f47a7/attachment.pgp