[Xcb] XRenderCompositeString32

[Vincent Torri]

On Thu, 12 Oct 2006, Russell Shaw wrote:

> Hi,
> In XRender.h, we have:
>
> void
> XRenderCompositeString32 (Display		    *dpy,
> 			  int			    op,
> 			  Picture		    src,
> 			  Picture		    dst,
> 			  _Xconst XRenderPictFormat *maskFormat,
> 			  GlyphSet		    glyphset,
> 			  int			    xSrc,
> 			  int			    ySrc,
> 			  int			    xDst,
> 			  int			    yDst,
> 			  _Xconst unsigned int	    *string,
> 			  int			    nchar);
>
>
> In xcb/render.h, we have:
>
> xcb_void_cookie_t
> xcb_render_composite_glyphs_32_checked (xcb_connection_t        *c,
>                                        uint8_t                  op,
>                                        xcb_render_picture_t     src,
>                                        xcb_render_picture_t     dst,
>                                        xcb_render_pictformat_t  mask_format,
>                                        xcb_render_glyphset_t    glyphset,
>                                        int16_t                  src_x,
>                                        int16_t                  src_y,
>                                        uint32_t 
> glyphcmds_len,
>                                        const uint8_t           *glyphcmds)
>
>
> In xcb_render_composite_glyphs_32_checked(), shouldn't there be "const 
> uint32_t *glyphcmds"
> instead of "const uint8_t *glyphcmds" ?
>
> It is misleading, because glyphcmds_len could be mistaken for the byte length 
> instead of the
> number of uint32_t elements.

I think that you are right 
(http://keithp.com/~keithp/render/protocol.html)

I also think that there is the same error for 
xcb_render_composite_glyphs_16

Vincent