[Xcb] Structure pointers

Russell Shaw rjshaw at netspace.net.au
Thu Oct 12 09:44:32 PDT 2006


Hi,
In this prototype (render.c):

xcb_void_cookie_t
xcb_render_fill_rectangles (xcb_connection_t      *c,
                             uint8_t                op,
                             xcb_render_picture_t   dst,
                             xcb_render_color_t     color,
                             uint32_t               rects_len,
                             const xcb_rectangle_t *rects)

the parameter: "xcb_render_color_t color" is passing a whole structure
by value instead of as a pointer. Wouldn't this be more C-like and
efficient?:

xcb_void_cookie_t
xcb_render_fill_rectangles (xcb_connection_t      *c,
                             uint8_t                op,
                             xcb_render_picture_t   dst,
                             xcb_render_color_t     *color,     /* pointer */
                             uint32_t               rects_len,
                             const xcb_rectangle_t *rects)


More information about the Xcb mailing list