[Xcb] about api changes

Thomas Hunger hto at arcor.de
Wed Jun 6 13:01:58 PDT 2007


Hi,

> - iterator "mess" (e.g. quite some duplication of code for those
> iterators which just point to an entry in an array; maybe only
> having iterator_t *xcb_...s() and int xcb_..._length() for that

I could not find anything in the archives about this. Do you have a 
pointer or maybe a few examples?

> type of iterator), ".rem" is named +/- well
See:
http://lists.freedesktop.org/archives/xcb/2007-February/002570.html

My vote is for .remaining (or anything, but a full word)

> - some points about naming normalization
I'd like to have one change: currently we convert e.g. 

"CHAR2B" to "xcb_char2b_t"

but name="data2" will become
xcb_glx_vendor_private_with_reply_data_2

For consistency I think we should either 
a) Always have numbers stick to the previous word (handle them as
   lower case letters) or
b) Always separate them (e.g. xcb_char_2_b_t)

I vote for a).

> - should the _request stuff be part of the public api? (e.g.
> compile time speedup if the headers are smaller)

Maybe we could collect Ideas in this thread and put the ones we agree 
on into the wiki?

Tom


More information about the Xcb mailing list