[Xcb] Native win32 port - patches :)

Jeetu Golani jeetu.golani at gmail.com
Fri May 9 06:47:27 PDT 2008


Hi,

I'm back from my hols :(.......and I'm resubmitting my patches.

Julien I've tried and made the changes you requested......would appreciate if 
you could verify if this is in order.

Bye for now

On Thursday 08 May 2008, Julien Cristau wrote:
> On Wed, Apr 23, 2008 at 21:37:53 +0530, Jeetu Golani wrote:
> > Hi everyone,
> >
> > I'm submitting my patches for the win32 port of XCB. I would appreciate
> > if people could look into it and give me feedback....hope it's of use to
> > someone :)
>
> Your patches are reversed, can you fix that?  Also, the file
> patch_win32_xcb_auth_c in your tarball is itself a tarball and doesn't
> contain any change to xcb_auth.c (actually, it would be nicer if you
> posted the patches uncompressed).
> Please remove the useless "changes for win32" comments.
> Please don't mix whitespace changes with your win32 changes.
> I'll stop there, because reading reversed patches makes my head hurt.
>
> Cheers,
> Julien


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_win32_xcb_auth_c
Type: text/x-diff
Size: 871 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0005.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_win32_xcb_conn_c
Type: text/x-diff
Size: 4146 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0006.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_win32_xcb_h
Type: text/x-diff
Size: 615 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0007.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_win32_xcb_util_c
Type: text/x-diff
Size: 3410 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0008.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_win32_xcb_in_c
Type: text/x-diff
Size: 2677 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0009.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: windefs.h
Type: text/x-chdr
Size: 1721 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080509/1c6b5c79/attachment-0001.h 


More information about the Xcb mailing list