[Xcb] [SRM] proposed upload of libxcb to lenny

Julien Cristau jcristau at debian.org
Wed May 27 12:01:52 PDT 2009


On Wed, May 27, 2009 at 11:52:43 -0700, Ian Osgood wrote:

> 
> On May 27, 2009, at 11:32 AM, Julien Cristau wrote:
> 
> > --- libxcb-1.1.orig/src/xcbint.h
> > +++ libxcb-1.1/src/xcbint.h
> > @@ -72,7 +72,7 @@
> >      pthread_cond_t cond;
> >      int writing;
> >
> > -    char queue[4096];
> > +    char queue[16384];
> >      int queue_len;
> >
> >      unsigned int request;
> 
> I'm surprised this is a raw literal. Shouldn't this be a symbol,  
> possibly configurable?
> 
> I think Jamey and Bart originally wanted a small value to make the  
> footprint smaller on memory-limited devices. The natural solution in  
> my eyes is to make this a constant having a 16K default so as not to  
> surprise Xlib users, and have a configure option to build libxcb with  
> a different sized buffer if desired.
> 
It's a configure option in 1.2 and master, I just needed a minimal patch
here.

http://cgit.freedesktop.org/xcb/libxcb/commit/?id=cebd482a20fcc2b2dae0683c38e917a3740638a6

Cheers,
Julien


More information about the Xcb mailing list