[Xcb] Win32 port -- git help
pharris at opentext.com
Fri Mar 26 07:16:48 PDT 2010
On 2010-03-26 00:15, Jeetu Golani wrote:
> Seems to have worked :)....thanks so much :).....need to test the code some
> more before I declare the code ready to be reviewed :)
I know you haven't declared it ready to be reviewed yet, but I took a
quick look anyway.
- Looks like you forgot to include windefs.h
- You include "windefs.h" in xcb.h - that's a public header, so it
should probably be <xcb/xcb_windefs.h> or similar, no?
- There's one WIN32 (should be _WIN32) in xcb_conn.c, and one in xcb_in.c
I know we already decided not to call WSAStartup in libxcb, but I'm
going to note for the archives that this dooms libxcb to be a static
library. This isn't a big deal, as libxcb was already doomed:
I'm just pointing it out for posterity, in case someone wants to make
libxcb DLL-compatible in the future.
Open Text Connectivity Solutions Group
Peter Harris http://connectivity.opentext.com/
Research and Development Phone: +1 905 762 6001
pharris at opentext.com Toll Free: 1 877 359 4866
More information about the Xcb